Skip to content

NO-JIRA: Bump o/api version to 4.19 tag#6035

Merged
enxebre merged 2 commits intoopenshift:mainfrom
enxebre:bump-o-api
Apr 14, 2025
Merged

NO-JIRA: Bump o/api version to 4.19 tag#6035
enxebre merged 2 commits intoopenshift:mainfrom
enxebre:bump-o-api

Conversation

@enxebre
Copy link
Copy Markdown
Member

@enxebre enxebre commented Apr 14, 2025

Without this bump the ocp GatewayAPI tests fail since the feature is not enable in default featureset and so the ingress operator doesn't install the CRDs

Run
go get github.com/openshift/api@release-4.19
go mod tidy
go mod vendor
make update

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@enxebre
Bump o/api version to 4.19 tag
d55a445 
Without this bump the ocp GatewayAPI tests fail since the feature is not enable in default featureset and so the ingress operator doesn't install the CRDs
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 14, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2025

@enxebre: This pull request explicitly references no jira issue.

Details

In response to this:

Without this bump the ocp GatewayAPI tests fail since the feature is not enable in default featureset and so the ingress operator doesn't install the CRDs

Run
go get github.com/openshift/api@release-4.19
go mod tidy
go mod vendor
make update

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from csrwng and sjenning April 14, 2025 12:40
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added area/api Indicates the PR includes changes for the API approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Apr 14, 2025
@bryan-cox
Copy link
Copy Markdown
Member

bryan-cox commented Apr 14, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2025

/retest-required

Remaining retests: 0 against base HEAD afc6136 and 2 for PR HEAD d55a445 in total

@openshift-ci openshift-ci Bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release and removed lgtm Indicates that a PR is ready to be merged. labels Apr 14, 2025
@bryan-cox
Copy link
Copy Markdown
Member

bryan-cox commented Apr 14, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Apr 14, 2025

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

@enxebre: Overrode contexts on behalf of enxebre: Red Hat Konflux / hypershift-operator-main-on-pull-request

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@enxebre
Copy link
Copy Markdown
Member Author

enxebre commented Apr 14, 2025

/override "Red Hat Konflux / control-plane-operator-enterprise-contract / control-plane-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

@cwbotbot
Copy link
Copy Markdown

cwbotbot commented Apr 14, 2025

Test Results

e2e-aws

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 14, 2025

@enxebre: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / control-plane-operator-enterprise-contract / control-plane-operator-main
  • Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aks
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-upgrade-hypershift-operator
  • ci/prow/e2e-kubevirt-aws-ovn-reduced
  • ci/prow/images
  • ci/prow/okd-scos-e2e-aws-ovn
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/verify
  • pull-ci-openshift-hypershift-main-e2e-aks
  • pull-ci-openshift-hypershift-main-e2e-aws
  • pull-ci-openshift-hypershift-main-e2e-aws-upgrade-hypershift-operator
  • pull-ci-openshift-hypershift-main-e2e-kubevirt-aws-ovn-reduced
  • pull-ci-openshift-hypershift-main-images
  • pull-ci-openshift-hypershift-main-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-hypershift-main-security
  • pull-ci-openshift-hypershift-main-unit
  • pull-ci-openshift-hypershift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "Red Hat Konflux / control-plane-operator-enterprise-contract / control-plane-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@enxebre enxebre merged commit 6c62eaa into openshift:main Apr 14, 2025
9 of 15 checks passed
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Apr 14, 2025

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202504141708.p0.g6c62eaa.assembly.stream.el9.
All builds following this will include this PR.

@alebedev87 alebedev87 mentioned this pull request Apr 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@bryan-cox bryan-cox

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@enxebre @openshift-ci-robot @bryan-cox @cwbotbot @openshift-bot