Skip to content

MGMT-20771: Enable disabling of Console capability#6183

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
linoyaslan:implement_generic_disable_capabilities
Jul 9, 2025
Merged

MGMT-20771: Enable disabling of Console capability#6183
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
linoyaslan:implement_generic_disable_capabilities

Conversation

@linoyaslan
Copy link
Copy Markdown
Contributor

@linoyaslan linoyaslan commented May 22, 2025 •
edited
Loading

What this PR does / why we need it:
This PR is part of expanding support for disabling openshift capabilities in hypershift. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

NOTE: OCPBUGS-57055 is a UX issue. Since the problem is limited to non-functional CRDs appearing, there’s no straightforward fix, and this behavior is already a known limitation in standalone OpenShift, it was decided not to block the “disable console” functionality in HyperShift because of it.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci Bot
Loading

@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console and OpenShiftSamples capabilities, both managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan linoyaslan marked this pull request as draft May 22, 2025 14:54
@openshift-ci openshift-ci Bot added do-not-merge/needs-area do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 22, 2025
@openshift-ci openshift-ci Bot requested review from csrwng and rtheis May 22, 2025 14:55
@openshift-ci openshift-ci Bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels May 22, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 22, 2025 •
edited by openshift-ci Bot
Loading

@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console and OpenShiftSamples capabilities, both managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch 3 times, most recently from 6197c5a to 0c8a121 Compare May 26, 2025 10:15
enxebre
enxebre reviewed May 26, 2025
View reviewed changes
Comment thread api/hypershift/v1beta1/hostedcluster_types.go Outdated
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch 2 times, most recently from fc50b9c to 46aa411 Compare May 26, 2025 12:13
@linoyaslan linoyaslan marked this pull request as ready for review May 26, 2025 12:15
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 26, 2025
@openshift-ci openshift-ci Bot requested review from enxebre and hasueki May 26, 2025 12:15
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch 2 times, most recently from 054418e to c6dc38c Compare May 26, 2025 12:51
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 26, 2025 •
edited by openshift-ci Bot
Loading

@linoyaslan: This pull request references MGMT-20682 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
This PR is the first step in expanding support for disabling openshift capabilities in hypershift. Currently, only the ImageRegistry capability can be disabled. This change adds support for disabling the Console and OpenShiftSamples capabilities, both managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from c6dc38c to 2ead0fa Compare May 26, 2025 12:58
@enxebre
Copy link
Copy Markdown
Member

enxebre commented May 26, 2025

Let's update the PR to include support for only one new capability. Then please let's add e2e validation for it within TestCreateClusterCustomConfig, see EnsureImageRegistryCapabilityDisabled as an example. These capabilities should be more straight forward if they don't have management side implications

@cwbotbot
Copy link
Copy Markdown

cwbotbot commented May 26, 2025 •
edited
Loading

Test Results

e2e-aws

Failed Tests

Total failed tests: 2

  • TestCreateClusterCustomConfig
  • TestCreateClusterCustomConfig/ValidateHostedCluster

e2e-aks

@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from e732070 to 8b39f22 Compare June 19, 2025 12:39
@linoyaslan
Copy link
Copy Markdown
Contributor Author

linoyaslan commented Jun 19, 2025

/retest

1 similar comment
@linoyaslan
Copy link
Copy Markdown
Contributor Author

linoyaslan commented Jun 19, 2025

/retest

enxebre
enxebre reviewed Jul 3, 2025
View reviewed changes
Comment thread api/hypershift/v1beta1/hostedcluster_types.go
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from 8b39f22 to e290041 Compare July 3, 2025 16:39
@linoyaslan linoyaslan requested a review from enxebre July 3, 2025 16:40
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 3, 2025 •
edited by openshift-ci Bot
Loading

@linoyaslan: This pull request references MGMT-20771 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

What this PR does / why we need it:
This PR is part of expanding support for disabling openshift capabilities in hypershift. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.

NOTE: OCPBUGS-57055 is a UX issue. Since the problem is limited to non-functional CRDs appearing, there’s no straightforward fix, and this behavior is already a known limitation in standalone OpenShift, it was decided not to block the “disable console” functionality in HyperShift because of it.

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@linoyaslan
Copy link
Copy Markdown
Contributor Author

linoyaslan commented Jul 6, 2025

/retest

1 similar comment
@linoyaslan
Copy link
Copy Markdown
Contributor Author

linoyaslan commented Jul 7, 2025

/retest

@bryan-cox
Copy link
Copy Markdown
Member

bryan-cox commented Jul 7, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2025
@linoyaslan
Copy link
Copy Markdown
Contributor Author

linoyaslan commented Jul 7, 2025

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 7, 2025

/retest-required

Remaining retests: 0 against base HEAD 70855f0 and 2 for PR HEAD e290041 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 7, 2025

/retest-required

Remaining retests: 0 against base HEAD c407cc9 and 1 for PR HEAD e290041 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 8, 2025

/retest-required

Remaining retests: 0 against base HEAD 3f7adef and 0 for PR HEAD e290041 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jul 8, 2025

/hold

Revision e290041 was retested 3 times: holding

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@enxebre
Copy link
Copy Markdown
Member

enxebre commented Jul 8, 2025

/test e2e-aws

@linoyaslan
Copy link
Copy Markdown
Contributor Author

linoyaslan commented Jul 8, 2025

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2025
@linoyaslan linoyaslan force-pushed the implement_generic_disable_capabilities branch from e290041 to 09301e4 Compare July 9, 2025 04:39
@linoyaslan
MGMT-20771: Enable disabling of Console capability
742ac94 
This commit is part of expanding support for disabling openshift capabilities in hypershift. This change adds support for disabling the Console capability, who managed by the Cluster Version Operator. Additional capabilities will be supported in future updates.
Note: OCPBUGS-57055 is a UX issue. Since the problem is limited to non-functional CRDs appearing, there’s no straightforward fix, and this behavior is already a known limitation in standalone OpenShift, it was decided not to block the “disable console” functionality in HyperShift because of it.
@enxebre
Copy link
Copy Markdown
Member

enxebre commented Jul 9, 2025

/lgtm

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Jul 9, 2025

/test e2e-aks

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Jul 9, 2025

/override "Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 9, 2025

@enxebre: Overrode contexts on behalf of enxebre: Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main, Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main

Details

In response to this:

/override "Red Hat Konflux / hypershift-operator-enterprise-contract / hypershift-operator-main"
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 9, 2025

@linoyaslan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@rtheis rtheis Awaiting requested review from rtheis

@hasueki hasueki Awaiting requested review from hasueki

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@enxebre enxebre

@muraee muraee

@bryan-cox bryan-cox

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@linoyaslan @openshift-ci-robot @enxebre @cwbotbot @muraee @bryan-cox @openshift-merge-robot