Fix NodePool CLI#922
Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom Jan 26, 2022
Merged
Conversation
openshift-ci
Bot
added
the
needs-rebase
Fix three issues added in PR openshift#832: * Fix Global flags to use PersistentFlag insead Flag * Change all objects to be passed as pointers in order to have command values passed * In cmd/log the way passing keysAndValues parameter
nirarg
force-pushed
the
nodepool-cli-fix
branch
from
4fcfbcf to
a0ea828
Compare
openshift-ci
Bot
removed
the
needs-rebase
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, nirarg The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
lgtm
Contributor
|
@nirarg: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix three issues added in PR #832:
Which issue(s) this PR fixes:
Fixes #921
Checklist