dispatcher: parse FROM --after=<stage>

[jlebon]

This allows defining a dependency on another stage for cases when buildah otherwise wouldn't be able to automatically infer it. See containers/buildah#6621 for details.

The corresponding buildah patch making use of this will have more info.

For now, makes this an explicitly error if used with the dockerclient. I don't see the use case for it there currently given that this flag is to help leverage a buildah-specific feature.

Assisted-by: Claude Opus 4.5

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jlebon
Once this PR has been reviewed and has the lgtm label, please assign tomsweeneyredhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jlebon]

CI failure here I think is unrelated. Looks like a Docker API version mismatch.

FWIW, I got this to work locally by setting DOCKER_API_VERSION=1.44.

[nalind]

This either needs to implement --after for the dockerclient implementation, or add logic to have it error out if the flag is used. We don't want it to just be ignored, giving people a reason to think it'll have the desired effect, when it won't.

[jlebon]

This either needs to implement --after for the dockerclient implementation, or add logic to have it error out if the flag is used. We don't want it to just be ignored, giving people a reason to think it'll have the desired effect, when it won't.

Updated!

I went with just erroring out for now as mentioned in the commit message:

For now, makes this an explicitly error if used with the dockerclient. I don't see the use case for it there currently given that this flag is to help leverage a buildah-specific feature.

[TomSweeneyRedHat]

@jlebon seems you have a build failure here....

[jlebon]

@jlebon seems you have a build failure here....

One of them was failing in the conforming tests with what I mentioned in #316 (comment). The other one didn't seem to have any obvious error. It looks truncated?

I repushed to force a retrigger. Let's see what happens...

[openshift-ci]

@jlebon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jlebon]

It's persistent. I think CI just needs some love. Looks like that's happening in #317. :)