base/*: Set skip_missing_names_on_install=0 in /etc/yum.conf#11
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Aug 12, 2019
Merged
Conversation
openshift-ci-robot
added
the
size/S
chancez
force-pushed
the
skip_missing_on_install_fail
branch
from
2dac391 to
d1a1afb
Compare
base/Dockerfile.rhel
Outdated
| yum install -y --setopt=tsflags=nodocs ${INSTALL_PKGS} && \ | ||
| yum clean all && rm -rf /var/cache/* | ||
| yum clean all && rm -rf /var/cache/* && \ | ||
| echo 'skip_missing_names_on_install=0' >> /etc/yum.conf |
Contributor
There was a problem hiding this comment.
Do we need a leading newline?
Contributor
Author
There was a problem hiding this comment.
Not that I saw when I tested in the container manually.
Contributor
Author
|
/retest |
Member
|
/lgtm |
openshift-ci-robot
added
lgtm
pecameron
reviewed
Aug 12, 2019
pecameron
left a comment
pecameron
left a comment
There was a problem hiding this comment.
Do we need to set the yum.conf file before the yum install?
Member
|
/lgtm cancel
Good idea, I think the main goal was to fix downstream images but I think reordering things here as well makes sense. |
openshift-ci-robot
removed
lgtm
base/Dockerfile
Outdated
| yum clean all && \ | ||
| mkdir -p /var/lib/origin | ||
| mkdir -p /var/lib/origin && \ | ||
| echo 'skip_missing_names_on_install=0' >> /etc/yum.conf |
Contributor
There was a problem hiding this comment.
Yeah move this up and then nuke rpm INSTALL_PKGS
Ensure yum install fails if a package is missing.
chancez
force-pushed
the
skip_missing_on_install_fail
branch
from
d1a1afb to
56fc2fe
Compare
Contributor
Author
|
Updated to move the config option before yum install. |
openshift-ci-robot
added
size/XS
Member
|
/lgtm |
openshift-ci-robot
added
lgtm
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chancez, sdodson, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hardys
pushed a commit
to hardys/ironic-image
that referenced
this pull request
Aug 20, 2019
This is a dependency of the ironic packages (via the python2-oslo-db package) already, and copying this dependency to the downstream el8 based dockerfile has caused issues since[1] made some of the image building checks stricter, I assume this is because the package name is different but I don't have a specfile reference atm. This has led to [2] failing CI, and rather than just fix that downstream we should probably make things consistent and remove this spuruious install, then let RPM dependencies defined by the package maintainers do the right thing on each platform? [1] openshift/images#11 [2] openshift#15
hardys
pushed a commit
to hardys/ironic-image
that referenced
this pull request
Aug 20, 2019
This is a dependency of the ironic packages (via the python2-oslo-db package) already, and copying this dependency to the downstream el8 based dockerfile has caused issues since[1] made some of the image building checks stricter, I assume this is because the package name is different but I don't have a specfile reference atm. This has led to [2] failing CI, and rather than just fix that downstream we should probably make things consistent and remove this spuruious install, then let RPM dependencies defined by the package maintainers do the right thing on each platform? [1] openshift/images#11 [2] openshift#15
This was referenced Aug 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure yum install fails if a package is missing.