Skip to content

[release-4.2] Bug 1826609: Refactoring collector, add Doc and doc generator#109

Closed
martinkunc wants to merge 69 commits intoopenshift:release-4.2from
martinkunc:release-4-2-add-documentation
Closed

[release-4.2] Bug 1826609: Refactoring collector, add Doc and doc generator#109
martinkunc wants to merge 69 commits intoopenshift:release-4.2from
martinkunc:release-4-2-add-documentation

Conversation

@martinkunc
Copy link
Copy Markdown
Contributor

@martinkunc martinkunc commented May 18, 2020

This picks #95 and updates dependencies.

natiiix and others added 30 commits May 14, 2020 08:41
@natiiix @martinkunc
Initialize new Go module based on glide.yaml
55d1ea8
@natiiix @martinkunc
Update dependencies to Kubernetes 1.16
57fac41
@eparis @martinkunc
Cherry-pick cc22b34 Collect the proxy config
e94367d 
We anonomize basically everything, but at least we'd know if it was set.
@natiiix @martinkunc
Update vendor Make rule to use go mod
fffe45e
@natiiix @martinkunc
Cherry-pick f98669a Delete obsolete Glide files
b8e2ebd 
They shouldn't be necessary anymore thanks to the switch to Go modules.
@natiiix @martinkunc
Decrease Go module version to 1.12
9f6dcac 
For better compatibility with other OpenShift repositories / modules.
@tisnik @martinkunc
Howto unit test in README.md
117d068
@SamuelStuchly @martinkunc
service and service-monitor manifests added, to allow communication b…
1a662ac 
…etween prometheus and operator
@SamuelStuchly @martinkunc
cluster-monitoring=true label added
6d40c15
@SamuelStuchly @martinkunc
added rbac rule for prometheus and prometheus_rolebinding file, also …
15feb8f 
…renamed files to achieve the right order
@SamuelStuchly @martinkunc
metric type changed to counter,name of the metric changed to comply w…
169b640 
…ith instrumentation guidelines

counters should have '_total' suffix
@SamuelStuchly @martinkunc
caFile mount location added.
9da9b8d
@SamuelStuchly @martinkunc
added volume and mountPath for serving-cert to resolve tls bad certif…
35d06c5 
…icate issue
@mfojtik @martinkunc
gather: consider restarting pods as not healthy
e64613e
@mfojtik @martinkunc
Cherry-pick cf52c01 gather: include network events for namespace that…
29a38c1 
… has degraded operator
@mfojtik @martinkunc
Cherry-pick 55c523a go.mod: pin the correct levels of kube and opensh…
63a7c3b 
…ift libraries
@mfojtik @martinkunc
bump(*): pin to kube 1.16.2
efaef2b
@mfojtik @martinkunc
Cherry-pick b14ceee manifests: update cluster role to allow listing e…
483baa7 
…vents
@SamuelStuchly @martinkunc
api to metrics service changed from prometheus to legacyregistry
f24d1c0
@csrwng @martinkunc
Add manifest annotations for hosted deployment exclusions
d4aac3c
@smarterclayton @martinkunc
vendor: Pick up latest library-go for fixes with fileobserver
ab54391 
service-ca.crt changes would fail in some cases.
@smarterclayton @martinkunc
gather: Collect some prometheus metrics for the cluster
018a3bd 
Grab running alerts and etcd object counts from /federate using the
gather client. More metrics will be added later.
@smarterclayton @martinkunc
periodic: Reset the sync interval in gather when it changes
1033562 
Ensures that if we change the sync interval that we gather more
frequently.
@smarterclayton @martinkunc
insightsclient: Report the amount of data written
86ef774 
Allow us to judge from logs how much we are sending.
@mfojtik @martinkunc
bump(*): fix fileobserver logging
7ccc277
@martinkunc
Cherry-pick 1c341e6 initial commit for tests
6eab5ff
@martinkunc
Cherry-pick e2a31d9 Fixed unit test command
671b434
@martinkunc
removed unused var
35f423d
@martinkunc
added TestOptOutOptIn and moved some code to functions
d01a541
@tisnik @martinkunc
cherry-pick faf52d4 Add Pavel Tisnovsky into list of repo owners
f74a6ce
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 18, 2020

@martinkunc: This pull request references Bugzilla bug 1826608, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "4.3.z" instead
  • expected dependent Bugzilla bug 1826607 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
  • expected dependent Bugzilla bug 1826607 to target a release in 4.3.0, 4.3.z, but it targets "4.4.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1826608: Refactoring collector, add Doc and doc generator #108

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 18, 2020
@martinkunc martinkunc changed the title [release-4.3] Bug 1826608: Refactoring collector, add Doc and doc generator #108 [release-4.3] Bug 1826608: Refactoring collector, add Doc and doc generator May 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 18, 2020

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: martinkunc
To complete the pull request process, please assign mfojtik
You can assign the PR to them by writing /assign @mfojtik in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@martinkunc martinkunc changed the title [release-4.3] Bug 1826608: Refactoring collector, add Doc and doc generator [release-4.2] Bug 1826609: Refactoring collector, add Doc and doc generator May 18, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 18, 2020

@martinkunc: This pull request references Bugzilla bug 1826609, which is invalid:

  • expected dependent Bugzilla bug 1826608 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.2] Bug 1826609: Refactoring collector, add Doc and doc generator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ashcrow ashcrow added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label May 29, 2020
@martinkunc
Copy link
Copy Markdown
Contributor Author

martinkunc commented Jul 8, 2020

@ashcrow The reason for backporting this refactoring code is to be proactive and prepare 4.2 branch for any possible further pull requests. Without merging the refactoring, merge of future changes to 4.2 would need quite an effort with merging.

@tremes
Copy link
Copy Markdown
Contributor

tremes commented Sep 22, 2020

OCP 4.2 is EOL so we can close this PR (I don't have permissions to do so)

@tremes
Copy link
Copy Markdown
Contributor

tremes commented Sep 28, 2020

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 28, 2020

@tremes: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexandrevicenzi alexandrevicenzi Awaiting requested review from alexandrevicenzi

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

No one assigned

Labels

bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.