Skip to content

gather: include events in report#36

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mfojtik:network-events
Oct 31, 2019
Merged

gather: include events in report#36
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mfojtik:network-events

Conversation

@mfojtik
Copy link
Copy Markdown
Contributor

@mfojtik mfojtik commented Oct 30, 2019 •
edited
Loading

Collect all events for openshift- namespaces that are not older than 1 hour (for starter). The events are compacted to minimize the size in payload. If we still see big file, we can tweak the 1h interval to 30 min.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
smarterclayton
smarterclayton reviewed Oct 30, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go Outdated
smarterclayton
smarterclayton reviewed Oct 30, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go Outdated
smarterclayton
smarterclayton reviewed Oct 30, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go Outdated
@mfojtik mfojtik changed the title gather: include network events for namespace that has degraded operator gather: include events in report Oct 30, 2019
@mfojtik mfojtik force-pushed the network-events branch 2 times, most recently from 9cc0e09 to ab444cc Compare October 30, 2019 18:22
@mfojtik
Copy link
Copy Markdown
Contributor Author

mfojtik commented Oct 30, 2019

/cherrypick release-4.2

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Oct 30, 2019

@mfojtik: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Copy Markdown
Contributor Author

mfojtik commented Oct 30, 2019 •
edited
Loading

@smarterclayton @iNecas the collected events is ~70kb decompressed, it is much smaller compressed and it is 70kb I would pay in gold to have to debug degraded clusters as the events provide timeline when problems happen (we can detect broken CNI for example).

Also events contain timeline of how/when operators changed states.

I'm optimistic and want to backport this to 4.2 so we can help already broken clusters :)

mfojtik
mfojtik commented Oct 30, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go
smarterclayton
smarterclayton reviewed Oct 30, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go
smarterclayton
smarterclayton reviewed Oct 30, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go Outdated
@mfojtik mfojtik force-pushed the network-events branch 2 times, most recently from 96cec96 to eaf7a83 Compare October 30, 2019 19:41
smarterclayton
smarterclayton reviewed Oct 30, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go Outdated
@mfojtik mfojtik force-pushed the network-events branch 2 times, most recently from edaf1b2 to a171f41 Compare October 31, 2019 19:19
smarterclayton
smarterclayton reviewed Oct 31, 2019
View reviewed changes
Comment thread pkg/gather/clusterconfig/clusterconfig.go Outdated
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 31, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mfojtik,smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 9c0f1e5 into openshift:master Oct 31, 2019
@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Oct 31, 2019

@mfojtik: #36 failed to apply on top of branch "release-4.2":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	pkg/gather/clusterconfig/clusterconfig.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/gather/clusterconfig/clusterconfig.go
CONFLICT (content): Merge conflict in pkg/gather/clusterconfig/clusterconfig.go
Patch failed at 0001 gather: include network events for namespace that has degraded operator
Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik mfojtik mentioned this pull request Nov 1, 2019
Merged
@iNecas
Copy link
Copy Markdown
Contributor

iNecas commented Nov 1, 2019

@mfojtik mind updating the openshift docs as well with details on this change? https://github.com/openshift/openshift-docs/blob/master/modules/insights-operator-what-information-is-collected.adoc

@mfojtik
Copy link
Copy Markdown
Contributor Author

mfojtik commented Nov 1, 2019

@iNecas openshift/openshift-docs#17816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

1 more reviewer

@smarterclayton smarterclayton smarterclayton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mfojtik @openshift-cherrypick-robot @smarterclayton @openshift-ci-robot @iNecas @openshift-merge-robot