Bug 1991860: Don't try to record an empty Record if gatherClusterConfigV1 fails#485
Conversation
Currently, gatherClusterConfigV1 returns (Record{}, error) on failure,
and its caller appends the empty Record into its results; that
later crashes in Record.Filename() because Record.Item is nil.
Instead, be more similar to the sibling function and return a []Record{},
which allows gatherClusterConfigV1 to return no records.
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
openshift-ci
Bot
added
the
approved
|
@tremes: An error was encountered querying GitHub for users with public email (dmisharo@redhat.com) for bug 1991860 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details. Full error message.
non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
openshift-ci
Bot
added
bugzilla/severity-medium
|
@tremes: This pull request references Bugzilla bug 1991860, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dmisharo@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
natiiix
left a comment
natiiix
left a comment
There was a problem hiding this comment.
Tested locally that it gathers under normal circumstanes and that the test passes. I'm not really use how to simulate the situation requires to trigger the original issue, but no destructive changes have been made, so I have no reason to believe anything could have stopped working as a result of this PR.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natiiix, tremes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@tremes: All pull requests linked via external trackers have merged: Bugzilla bug 1991860 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Recordin thegatherClusterConfigV1record.Itemis not empty before actual recording + basic testCategories
Sample Archive
No new data
Documentation
No update
Unit Tests
Test added in:
pkg/recorder/recorder_test.goPrivacy
Yes. There are no sensitive data in the newly collected information.
Changelog
Breaking Changes
No
References
https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=1991860
https://access.redhat.com/solutions/???