Skip to content

Bug 1767719: Fix the event reporting in insights operator#56

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.2from
mfojtik:fix-event-report-4.2
Nov 28, 2019
Merged

Bug 1767719: Fix the event reporting in insights operator#56
openshift-merge-robot merged 2 commits intoopenshift:release-4.2from
mfojtik:fix-event-report-4.2

Conversation

@mfojtik
Copy link
Copy Markdown
Contributor

@mfojtik mfojtik commented Nov 27, 2019

The previous backport only backported the network events capture, not all events. This will revert the previous backport and pick the correct commits from release-4.3.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 27, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mfojtik: This pull request references Bugzilla bug 1767719, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1767719: Fix the event reporting in insights operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 27, 2019
@mfojtik mfojtik added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2019
@mfojtik
Copy link
Copy Markdown
Contributor Author

mfojtik commented Nov 27, 2019

self-lgtm as this is only correcting already approved backport.

patch manager: can we get this in early in the cycle? it is improving our observability into failed telemetry clusters and we kind of needed this yesterday.

@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit b996fe5 into openshift:release-4.2 Nov 28, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@mfojtik: All pull requests linked via external trackers have merged. Bugzilla bug 1767719 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1767719: Fix the event reporting in insights operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants