Bug 1821149: Cherry-pick release 4.3 Support for specific http proxy for the service by martinkunc · Pull Request #91 · openshift/insights-operator

martinkunc · 2020-04-07T05:42:08Z

Applied same commits as in #87

openshift-ci-robot · 2020-04-07T05:42:11Z

@martinkunc: This pull request references Bugzilla bug 1821149, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
expected dependent Bugzilla bug 1820595 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-07T05:44:26Z

/bugzilla refresh

openshift-ci-robot · 2020-04-07T05:44:29Z

@martinkunc: This pull request references Bugzilla bug 1821149, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "4.3.0" instead
expected dependent Bugzilla bug 1820595 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-07T05:49:03Z

/bugzilla refresh

openshift-ci-robot · 2020-04-07T05:49:06Z

@martinkunc: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-07T06:06:21Z

@jwforres Could I ask for approving the cherry-pick with cherry-pick-approved label please ?

alexandrevicenzi · 2020-04-07T08:51:20Z

/lgtm

martinkunc · 2020-04-07T09:35:23Z

/retest

openshift-bot · 2020-04-07T09:54:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

jwforres · 2020-04-07T13:38:42Z

Patch manager changes weekly. The current patch manager will look for any PRs that are ready to merge on Wednesday to Friday. This PR is currently not ready for patch manager approval since it still has invalid bug labels. Patch managers will not override bugzilla labels unless it is an exceptional circumstance. Please get QE to verify your bug in 4.4 and then refresh your bugzilla labels.

openshift-bot · 2020-04-10T01:00:34Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-10T01:00:36Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-11T01:01:19Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-11T01:01:42Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-12T01:01:17Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-12T01:01:20Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-13T01:01:16Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-13T01:01:19Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-14T01:00:45Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-14T01:00:48Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-15T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-15T01:01:07Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-16T01:01:34Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-16T01:01:37Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-04-19T01:01:36Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-04-20T01:01:32Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-04-20T01:01:35Z

@openshift-bot: This pull request references Bugzilla bug 1821149, which is invalid:

expected dependent Bugzilla bug 1820633 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-04-20T09:23:15Z

/lgtm

alexandrevicenzi · 2020-04-20T09:23:31Z

/retest

martinkunc · 2020-04-20T11:11:28Z

/bugzilla refresh

openshift-ci-robot · 2020-04-20T11:12:37Z

@martinkunc: This pull request references Bugzilla bug 1821149, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1820633 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1820633 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

russellb · 2020-04-22T18:14:12Z

@martinkunc Hi, I'm the patch manager this week.

I'm pretty confused by this PR. It references the 4.5 and 4.4 versions of the PR, but the commits in each don't line up. 4.5 had 7 commits, 4.4 had 10, and then this one has 9? Can you take a look at cleaning up the commit history here?

…rtinkunc/insights-operator into allow-specific-http-proxy-from-secret

openshift-ci-robot · 2020-04-23T16:01:11Z

@martinkunc: This pull request references Bugzilla bug 1821149, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1820633 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1820633 targets the "4.4.0" release, which is one of the valid target releases: 4.4.0, 4.4.z
bug has dependents

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

martinkunc · 2020-04-23T16:02:41Z

/retest

openshift-ci-robot · 2020-04-23T18:12:04Z

@martinkunc: you cannot LGTM your own PR.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

alexandrevicenzi · 2020-04-24T13:07:57Z

/lgtm

openshift-ci-robot · 2020-04-24T13:08:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexandrevicenzi, martinkunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [alexandrevicenzi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-04-24T17:19:45Z

@martinkunc: All pull requests linked via external trackers have merged: openshift/insights-operator#91. Bugzilla bug 1821149 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 7, 2020

openshift-ci-robot requested review from derekwaynecarr and smarterclayton April 7, 2020 05:42

openshift-ci-robot assigned alexandrevicenzi Apr 7, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 7, 2020

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 20, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 20, 2020

martinkunc added 7 commits April 23, 2020 15:09

Support for specific http proxy for the service

7defc06

Updating vendor folder

f1f30cb

Unit tests for specific proxy settings

2a2c3da

Remove commented code block - moved above.

69fd075

Moving specific proxy to authorizer

d4aa77b

Support for specific http proxy for the service

023d951

Merge branch 'allow-specific-http-proxy-from-secret' of github.com:ma…

8901980

…rtinkunc/insights-operator into allow-specific-http-proxy-from-secret

martinkunc force-pushed the release-4.3 branch from dbf0650 to 8901980 Compare April 23, 2020 13:28

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020

russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 24, 2020

openshift-merge-robot merged commit b7270de into openshift:release-4.3 Apr 24, 2020

Conversation

martinkunc commented Apr 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 7, 2020

Uh oh!

martinkunc commented Apr 7, 2020

Uh oh!

openshift-ci-robot commented Apr 7, 2020

Uh oh!

martinkunc commented Apr 7, 2020

Uh oh!

openshift-ci-robot commented Apr 7, 2020

Uh oh!

martinkunc commented Apr 7, 2020

Uh oh!

alexandrevicenzi commented Apr 7, 2020

Uh oh!

martinkunc commented Apr 7, 2020

Uh oh!

openshift-bot commented Apr 7, 2020

Uh oh!

jwforres commented Apr 7, 2020

Uh oh!

openshift-bot commented Apr 10, 2020

Uh oh!

openshift-ci-robot commented Apr 10, 2020

Uh oh!

openshift-bot commented Apr 11, 2020

Uh oh!

openshift-ci-robot commented Apr 11, 2020

Uh oh!

openshift-bot commented Apr 12, 2020

Uh oh!

openshift-ci-robot commented Apr 12, 2020

Uh oh!

openshift-bot commented Apr 13, 2020

Uh oh!

openshift-ci-robot commented Apr 13, 2020

Uh oh!

openshift-bot commented Apr 14, 2020

Uh oh!

openshift-ci-robot commented Apr 14, 2020

Uh oh!

openshift-bot commented Apr 15, 2020

Uh oh!

openshift-ci-robot commented Apr 15, 2020

Uh oh!

openshift-bot commented Apr 16, 2020

Uh oh!

openshift-ci-robot commented Apr 16, 2020

Uh oh!

openshift-ci-robot commented Apr 19, 2020

Uh oh!

openshift-bot commented Apr 20, 2020

Uh oh!

openshift-ci-robot commented Apr 20, 2020

Uh oh!

alexandrevicenzi commented Apr 20, 2020

Uh oh!

alexandrevicenzi commented Apr 20, 2020

Uh oh!

martinkunc commented Apr 20, 2020

Uh oh!

openshift-ci-robot commented Apr 20, 2020

Uh oh!

russellb commented Apr 22, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

martinkunc commented Apr 23, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

alexandrevicenzi commented Apr 24, 2020

Uh oh!

openshift-ci-robot commented Apr 24, 2020

Uh oh!

openshift-ci-robot commented Apr 24, 2020

Uh oh!

martinkunc commented Apr 7, 2020 •

edited

Loading