Generate kubeconfigs during create ignition-configs
#1008
Conversation
When performing BYO RHEL installations we only call `create ignition-configs` and we'd like to have the generated kubeconfig created at that point as well. I had initially proposed moving it but it was suggested to add it rather than move it.
openshift-ci-robot
added
the
size/XS
sdodson
requested review from
abhinavdahiya,
russellb and
wking
and removed request for
russellb and
wking
cmd/openshift-install/create.go
Outdated
There was a problem hiding this comment.
This seems fine to me. We'll probably stuff manifest.json in here too once we have it pulled out into its own asset structure. But I'm fine handling that in follow-up work.
sdodson
force-pushed
the
kubeconfig-igition-configs
branch
from
861f4b9 to
16ef626
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest No retest bot on this repo? |
It's attached to this repo. I suspect the recent, enigmatic "We are investigating reports of degraded performance" GitHub issue delaying webhook delivery. But just in case the previous event was lost: /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
When performing BYO RHEL installations we only call
create ignition-configsand we'd like to have the generated kubeconfig created at that point as well. I had initially proposed moving it but it was suggested to add it rather than move it.