-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[AWS] Doc: Adding user doc/guide for AWS account and installation #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Doc: Adding user doc/guide for AWS account and installation #1030
Conversation
|
/assign crawford |
|
There are lots of PNGs here. Whose on the hook to keep those up to date ;) ? Can we replace some or all of them with text that's easier to maintain? |
|
We probably want a link to this from the README (like we have for libvirt here) to make these more discoverable. |
We can definitely winnow them down over time. The idea is to port in the existing doc in for these early drops. |
docs/user/aws/limits.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? What are the 21 for? Three masters with public IPs, and...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is. They may be occupied by the ALB targets, but they are assigned to ELBs. Also, one per instance is attached. I don't know why, private IPs assigned in the subnet via DHCP are permanent for the lifetime of the node (regardless of stops/starts). Usually, these are created so the same IP can be given/reassigned to another instance; I don't think this is a problem we have.
Done. Repushed with this. |
docs/user/aws/iam.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd personally add a note saying that using sts doesn't work. you can see more examples of failure here or in the issues section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd personally add a note saying that using sts doesn't work...
I'm fine with this. But note that the credentials operator is coming soon which will make it a lot easier to guard against improper-cred issues, so it's probably not worth sinking too much time into stopgap docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather keep this user guide as a "straight shot" guide ATM. Introducing other wrinkles may make this a lot more complicated than we'd want in this particular spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair point
|
Pushed in removal of additional non-ASCII quotes. |
|
Okay. They are all gone. So sorry! Thanks!
…On Wed, Jan 9, 2019 at 5:39 PM W. Trevor King ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In docs/user/aws/iam.md
<#1030 (comment)>:
> +Before proceeding with the OpenShift install, you should create a secondary IAM administrative user following the steps
+outlined here:
+
+[AWS: Creating an IAM User in Your AWS Account][user-create]
+
+## Step 1: Name User, Identify Programmatic Access
+
+In this step, you identify the IAM user name. We require programmatic access to AWS (via generated access key), check
+this box.
+
+
+
+## Step 2: Attach Administrative Policy
+
+Many permissions are required by the AWS installer. A specific set of policies and services will be identified at a
+future date so a specific policy can be created and attached. Until then, attach the predefined “AdministratorAccess”
Pushed in removal of additional non-ASCII quotes.
<#1030/#issuecomment-452883975>
Still a few left ;).
$ git describe origin/pr/1030
v0.9.0-master-13-g46d34cd
$ git grep -In '’\|“\|”' origin/pr/1030 -- docs/user/aws
origin/pr/1030:docs/user/aws/iam.md:22:future date so a specific policy can be created and attached. Until then, attach the predefined “AdministratorAccess”
origin/pr/1030:docs/user/aws/iam.md:29:Step 3 is optional and we’ll skip it.
origin/pr/1030:docs/user/aws/iam.md:33:Step 4 allows us to review the settings we’ve selected. Make sure your screen reflects your chosen name and
origin/pr/1030:docs/user/aws/limits.md:7:Below, we’ll identify OpenShift cluster needs and how those impact some of those limits.
origin/pr/1030:docs/user/aws/route53.md:33:To use the root domain, you’d create the hosted zone with the value "openshiftcorp.com". To use a subdomain, you'd
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1030 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOpIA45ufDdeAAZat2vtmKG-xzfoHFgks5vBm-fgaJpZM4Z37oT>
.
--
Stephen Cuppett
OpenShift Engineering
Red Hat <https://www.redhat.com>
<https://red.ht/sig>
|
|
/test tf-fmt |
|
/test images |
|
/test e2e-aws |
|
I've pushed d38b4e2 with a few more minor pivots. You can pull it in with: $ git pull https://github.com/wking/openshift-installer.git aws-doc-fixups
$ git rebase -i --autosquash HEAD^^or similar. Feel free to ignore any of those changes as you see fit ;). |
All taken. Thanks! |
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cuppett, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
1 similar comment
|
/test e2e-aws |
|
/test images |
|
/test e2e-aws |
|
/test images |
|
/test e2e-aws |
5 similar comments
|
/test e2e-aws |
|
/test e2e-aws |
|
/test e2e-aws |
|
/test e2e-aws |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Freeze stuff all landed. /retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Fixing an omission from b383cd7 (Adding user doc/guide for AWS account and installation, 2019-01-09, openshift#1030). While I'm doing pedantic things at the end of the file, also alphabetize the link defintions.
This PR adds user documentation for AWS account configuration and installation to the repo.
Original document (for those with access) located here:
https://docs.google.com/document/d/1KSnNtFFtMDosX_dN7fgTTSvFezxJumC6leIIXWu616U/edit?usp=sharing
@crawford @eparis