Skip to content

Conversation

@wking
Copy link
Member

@wking wking commented Aug 3, 2018

We already have something like this job from openshift/release#1044. The backing recipe for that job is here, originally from here. It's pushing to Docker's hub and Quay. So we can drop this Jenkins job and rely on Prow for these images.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 3, 2018
@abhinavdahiya
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Aug 3, 2018

If there's a place to drop a deprecation notice and migration link in https://quay.io/repository/coreos/tectonic-installer , someone wiith credentials should add them.

@openshift-merge-robot openshift-merge-robot merged commit 434f1cb into openshift:master Aug 3, 2018
@wking wking deleted the drop-jenkins-push branch August 3, 2018 23:59
clnperez added a commit to clnperez/installer that referenced this pull request Feb 3, 2022
* azure: Check HyperVGenerations for instance type

If an instance type that does not support HyperVGeneration version 1
then terraform returns an error mentioning there's support only for
V1. Adding a check during install config to check for the versions
supported by the instance type provided.

* Ensure removal of placement-groups during cluster destroy on AWS

* Adjust the startup order of httpd container

Run the httpd container after the coreos-downloader completes to ensure that the kernel parameters can be added correctly.

Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>

* Add IP outputs for IBM terraform instances

Add the IP addresses for IBM bootstrap and master nodes to allow
collecting of logs from those nodes.

* Revert "Bug 2035757: cluster-bootstrap/alibaba: set tear-down-delay to wait kube-apiserver rolls out on AlibabaCloud (openshift#5535)"

This reverts commit 6e2d76b.

With openshift/machine-config-operator#2919, it is no longer necessary to delay the teardown
of the bootstrap control plane. The cluster will no longer get into an unusable state when there is only a single
kube-apiserver pod running.

* baremetal: networkConfig field now accepts yaml instead of string value

The current patch allows the user to specify the content of the install-config networkConfig field directly as a yaml object. Content validation (for a generic yaml) is now carried on by the install config asset

* remove unused kube terraform provider

* vendor: update openshift/api to include some alibaba infra changes

* Update openshift/api to 6e0b1eb97188.
* Update kube modules to v0.23.0.
* Update controller-runtime to v0.11.0.
* Remove unused terraform-provider-kubernetes.

* hack: use go 1.17 for verifying codegen

The hack/verify-codegen.sh script was using an image that included
go 1.16. However, the updated k8s.io/json module calls the
`(reflect.StructField) IsExported` function, which is new in go 1.17.
Consequently, the script needs to be updated to use an image that
include go 1.17 rather than 1.16.

* Bump Fedora CoreOS to 35.20220116.2.0

* Alibaba: fix system disk category of bootstrap

Remove hard coding, support users can specify cloud_efficiency in regions
that do not support cloud_essd disk category

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* Alibaba: fix creating public record being skipped

If the user chooses a base domain for which there is no zone, creating
the A record in the zone is simply skipped rather than raising an error.

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* Alibaba: fix VSwitch subnets overlap

Fix the overlapping problem of the VSwitch subnet of the Nat gateway with
 the master node VSwitch subnets

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* remove unsupported options

* Add proxy for ironic-agent.service

Avoid the issue that ironic agent image cannot be downloaded due to network proxy.

Signed-off-by: Zhou Hao <zhouhao@fujitsu.com>

* Revert "remove unsupported options"

This reverts commit 2684f8d.

* Azure Stack: Add UPI Instructions for internal CA

Many Azure Stack environments use internal CAs. In these cases
special steps are needed for a UPI install.

* remove unsupported options for existing resources

* Alibaba: fix resource creation for existing network

When users use an existing network, no longer create Nat gateways and
EIPs

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* gen'd install configs yaml

* update alibaba for provider spec api changes

This change updates the alibaba provider spec usage related to the
vswitch, security groups, and resource group. The API for the provider
spec is changing to use a discriminated union to capture the various
methods for finding resources (by id, name, or tags).

It also updates several machine api references to note the bifurcated
nature of the api version between v1beta1 and v1.

* update vendor for latest Aliababa API changes

This change is to update the vendor references to support the Alibaba
resrouce reference updates to the API.

* remove validation related to unsupported options

* update validation for unsupported options

* openstack: Fix invalid-https-certificate detection

Fix the reference to an unbound variable; avoid incrementing the invalid
certificate counter in a subshell.

* Alibaba: fix support region list

Remove unsupport region Nanjing and Dubai.

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* Bug 2043297: bump RHCOS 4.10 bootimage metadata

These changes will update the RHCOS 4.10 bootimage metadata in the installer.
This change includes fixes for the following BZs:

Bug 2008521 - gcp-hostname service should correct invalid search entries in resolv.conf
Bug 2043296 - Ignition fails when reusing existing statically-keyed LUKS volume
Bug 2043721 - Installer bootstrap hosts using outdated kubelet containing bugs

This change will also introduce artifacts for for Aliyun, AWS GovCloud regions, and Nutanix.

Changes generated with:

$ cosa shell
[coreos-assembler]$ plume cosa2stream --target data/data/coreos/rhcos.json --distro rhcos --no-signatures \
--url https://rhcos-redirector.apps.art.xq1c.p1.openshiftapps.com/art/storage/releases aarch64=410.84.202201251203-0 \
ppc64le=410.84.202201251004-0 s390x=410.84.202201251002-0  x86_64=410.84.202201251210-0
Verification Steps:

Install a new 4.10 cluster
oc debug node/<node name> -- chroot /host rpm-ostree status
Verify that the deployment version matches the version from this PR
that matches the architecture you are testing on. (i.e. x86_64
should have version 410.84.202201251210-0)

* Bug 2045916: IBMCloud: Stop defaulting to dedicated storage profile

Move off the dedicated storage machine profile, as it has shown to
be less reliable for provisioning on IBM Cloud.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2045916

* Alibaba: fix destroy not exist security group

The destroyer should not error when it attempts to delete a security group
 that does not exist.

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* Alibaba: fix endpoint error in some regions

Update sdk and terraform provier version, and add some endpoints of ECS
 service to fix endpoint error.

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* Alibaba: update vendor

* Revert "update validation for unsupported options"

This reverts commit e5d628d.

* Revert "remove validation related to unsupported options"

This reverts commit 20f8626.

* Alibaba: support internal publish strategy

Support internal publish strategy for platform Alibaba Cloud

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

å

* Alibaba: fix installer index panic

Add NAT gateway validation to check the region whether support NAT gateway

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* remove validation for unsupported options

* Alibaba: fix destory exist private zone

Should not destroy pre-configured alicloud DNS private zone

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* Alibaba: fix validation of resource group ID

Fix resource group ID validation errors caused by pagination issues

Signed-off-by: sunhui <wb-sh373163@alibaba-inc.com>

* update custom image ostype

* Bug 2047258: Read GovCloud from RHCOS stream

AMIs for GovCloud regions have been added to the RHCOS stream. Remove
validation requiring users to provide an AMI.

* Remove Caleb Boylan from core installer reviewers

* aws: Remove non-public AWS regions from list of regions

When creating the install-config, the installer displays regions
of all partitions of AWS. Certain regions also need extra information
for the validation to work and should not be taken as input since we
only ask for the bare minimum amount of information to create the
install config.

The best approach here would be to only display all the public regions
of AWS and allow for other regions after the install-config is created
to allow for the user to add the extra information.

* openstack: Don't shortcut cloud scraping if quota is unavailable

This results in an incorrect failure to validate network capabilities
because network extensions weren't loaded.

Co-authored-by: rna-afk <anarayan@redhat.com>
Co-authored-by: Joel Speed <joel.speed@hotmail.co.uk>
Co-authored-by: Zhou Hao <zhouhao@fujitsu.com>
Co-authored-by: Christopher J Schaefer <cjschaef@us.ibm.com>
Co-authored-by: staebler <staebler@redhat.com>
Co-authored-by: Andrea Fasano <afasano@redhat.com>
Co-authored-by: OpenShift Merge Robot <openshift-merge-robot@users.noreply.github.com>
Co-authored-by: Vadim Rutkovsky <vrutkovs@redhat.com>
Co-authored-by: sunhui <wb-sh373163@alibaba-inc.com>
Co-authored-by: Jeff Nowicki <jnowicki@us.ibm.com>
Co-authored-by: patrickdillon <padillon@redhat.com>
Co-authored-by: Michael McCune <elmiko@redhat.com>
Co-authored-by: Pierre Prinetti <pierreprinetti@redhat.com>
Co-authored-by: Huijing Hei <hhei@redhat.com>
Co-authored-by: Kiran Thyagaraja <18704819+kirankt@users.noreply.github.com>
Co-authored-by: Matthew Booth <mbooth@redhat.com>
clnperez added a commit to clnperez/installer that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants