bootkube: Pass etcd images into MCO bootstrap

[cgwalters]

This was a missed corresponding change after
openshift/machine-config-operator@6f0f3ff
landed.

Ref: openshift/machine-config-operator#367

[abhinavdahiya]

This is different compared to other images. It would be nice if we keep the env like others.

[cgwalters]

This is different compared to other images. It would be nice if we keep the env like others.

OK, I reworked it.

/test e2e-aws

[cgwalters]

Ah OK...running with this locally I see on the master:

[root@osiris-master-0 ~]# crictl logs 102c45fdbb236
/bin/sh: line 6: /usr/local/bin/etcd: No such file or directory

[cgwalters]

Depends: openshift/machine-config-operator#384

[openshift-bot]

/retest

[abhinavdahiya]

openshift/machine-config-operator#384 merged

Let's try again

/retest

[cgwalters]

openshift/machine-config-operator#384 merged

Yeah but it's not in an update payload yet AIUI - last accepted one was ~7 hours ago: https://origin-release.svc.ci.openshift.org/

(I think installer pulls latest accepted right?)

[wking]

I think installer pulls latest accepted right?

Master builds default to latest accepted, but CI is latest master images (regardless of promotion gating).

[cgwalters]

Master builds default to latest accepted, but CI is latest master images (regardless of promotion gating).

Oh god the matrix of combinations I need to understand just expanded...

[abhinavdahiya]

from e2e-aws

level=error msg="Error: Error applying plan:"
level=error
level=error msg="1 error occurred:"
level=error msg="\t* module.bootstrap.aws_s3_bucket.ignition: 1 error occurred:"
level=error msg="\t* aws_s3_bucket.ignition: Error creating S3 bucket: TooManyBuckets: You have attempted to create more buckets than allowed"
level=error msg="\tstatus code: 400, request id: C0118BD0E3019AFE, host id: ykgc+MQizNapIl4gb3lnfWH89zNlDT7q0t8L5r+eFAFy+yxDL5e35BKHE2YpEmynR++Ar9DnTDs="

feels like need to wait for sometime before we retest

[cgwalters]

/test e2e-aws

[cgwalters]

Can this get approved+lgtm so it merges when tests start passing?

[abhinavdahiya]

Can this get approved+lgtm so it merges when tests start passing?

It would be nice if can try this patch locally and paste that here to make sure this works..

that's why i was trying to wait for atleast one successful ci run...

[cgwalters]

In that last run though the machine-config operator was fine:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1194/pull-ci-openshift-installer-master-e2e-aws/3474/artifacts/e2e-aws/clusteroperators.json

Specifically:

                 {
                        "lastTransitionTime": "2019-02-06T22:09:05Z",
                        "status": "False",
                        "type": "Failing"
                    }

We just died due to storage test flakes AFAICS.

[abhinavdahiya]

In that last run though the machine-config operator was fine:

https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/1194/pull-ci-openshift-installer-master-e2e-aws/3474/artifacts/e2e-aws/clusteroperators.json

Specifically:

                 {
                        "lastTransitionTime": "2019-02-06T22:09:05Z",
                        "status": "False",
                        "type": "Failing"
                    }

We just died due to storage test flakes AFAICS.

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, cgwalters

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinavdahiya]

/retest

[openshift-ci-robot]

@cgwalters: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack	658402b	link	/test e2e-openstack
ci/prow/e2e-libvirt	658402b	link	/test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wking]

I've filed openshift/etcd#3 to lay the groundwork for replacing our current, hard-coded etcdctl image with this one pulled from the update payload. That would obsolete my currently-in-flight #1060.