Skip to content

tls: admin.kubeconfig server trust#1288

Closed
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:admin-kubeconfig
Closed

tls: admin.kubeconfig server trust#1288
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:admin-kubeconfig

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Feb 21, 2019

The kube-apiserver has multiple potential serving certs with different
trust bundles. We need to include all of them in the admin.kubeconfig.

follow-up to #1232

/assign @abhinavdahiya

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: abhinavdahiya

If they are not already assigned, you can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The kube-apiserver has multiple potential serving certs with different
trust bundles.  We need to include all of them in the admin.kubeconfig.
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Feb 21, 2019

I updated the deprecated one.

@deads2k deads2k closed this Feb 21, 2019
Copy link
Copy Markdown
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@deads2k: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gofmt 9fddda7 link /test gofmt
ci/prow/e2e-aws 9fddda7 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants