types/vsphere: simplify vsphere platform#1591
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Apr 12, 2019
staebler:vsphere_trim_install_config
Merged
types/vsphere: simplify vsphere platform#1591openshift-merge-robot merged 1 commit intoopenshift:masterfrom staebler:vsphere_trim_install_config
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
staebler:vsphere_trim_install_config
Conversation
Remove most of the configuration from the vSphere platform, leaving only the options that a basic customer would need to get a cluster running.
openshift-ci-robot
added
the
size/XL
openshift-ci-robot
added
the
approved
Contributor
Author
$ cat <<EOF > install-config.yaml
apiVersion: v1beta4
baseDomain: devcluster.openshift.com
metadata:
name: mstaeble
networking:
machineCIDR: "139.178.89.192/26"
platform:
vsphere:
vCenter: vcsa.vmware.devcluster.openshift.com
username: me@e2e.local
password: you will never guess
datacenter: dc1
defaultDatastore: nvme-ds1
pullSecret: redacted
sshKey: redacted
EOF
$ openshift-install create manifests
INFO Consuming "Install Config" from target directory
$ cat manifests/cloud-provider-config.yaml
apiVersion: v1
data:
config: |+
[Global]
secret-name = vsphere-creds
secret-namespace = kube-system
insecure-flag = 1
[Workspace]
server = vcsa.vmware.devcluster.openshift.com
datacenter = dc1
default-datastore = nvme-ds1
folder = mstaeble
[VirtualCenter "vcsa.vmware.devcluster.openshift.com"]
datacenters = dc1
kind: ConfigMap
metadata:
creationTimestamp: null
name: cloud-provider-config
namespace: openshift-config
$ cat openshift/99_cloud-creds-secret.yaml
kind: Secret
apiVersion: v1
metadata:
namespace: kube-system
name: vsphere-creds
data:
vcsa.vmware.devcluster.openshift.com.username: bWVAZTJlLmxvY2Fs
vcsa.vmware.devcluster.openshift.com.password: eW91IHdpbGwgbmV2ZXIgZ3Vlc3M= |
Contributor
|
/retest |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, dav1x, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Failing tests:
[sig-storage] In-tree Volumes [Driver: emptydir] [Testpattern: Dynamic PV (default fs)] volumes should be mountable [Suite:openshift/conformance/parallel] [Suite:k8s]/retest |
8 tasks
Contributor
/retest |
Contributor
/retest |
Contributor
|
/retest |
Contributor
|
/retest |
Contributor
|
/test e2e-aws |
Contributor
|
/retest |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Jan 10, 2020
It's been vCenter since the property landed in 3e73413 (types/vsphere: simplify vsphere platform, 2019-04-10, openshift#1591). This commit fixes "vcenter" typos from 0ec07d0 (docs: vSphere installation docs, 2019-04-07, openshift#1545) and a947609 (docs/user: Standardize install-config property documentation, 2019-08-05, openshift#2162).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove most of the configuration from the vSphere platform, leaving only the options that a basic customer would need to get a cluster running.