Skip to content

openshift: update wait for kube-apiserver to correct namespace#1658

Closed
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:fix-ns-2
Closed

openshift: update wait for kube-apiserver to correct namespace#1658
deads2k wants to merge 1 commit intoopenshift:masterfrom
deads2k:fix-ns-2

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Apr 22, 2019

openshift.sh runs after bootkube and attemps to wait for the kube-apiserver to look healthy.
The wait is a little unusual in and of itself (you contacted the server, why wait), but
it should wait on the openshift-kube-apiserver namespace since that's the one that runs
the kube-apiserver.

You can see an example of the failing log here: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/648/pull-ci-openshift-machine-config-operator-master-e2e-aws-op/1668/artifacts/e2e-aws-op/bootstrap/openshift.service .

The grep I added should shrink the list:

Apr 22 17:35:04 ip-10-0-12-47 openshift.sh[1518]: Not all pods available yet. Waiting for 5 seconds...
Apr 22 17:35:09 ip-10-0-12-47 openshift.sh[1518]: Executing kubectl --namespace openshift-kube-apiserver get pods --output custom-columns=STATUS:.status.phase,NAME:.metadata.name --no-headers=true
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-1-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-2-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-2-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-3-ip-10-0-140-109.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-3-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Running     installer-3-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Running     kube-apiserver-ip-10-0-140-109.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Running     kube-apiserver-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Pending     kube-apiserver-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-1-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-2-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-2-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-3-ip-10-0-140-109.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-3-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-1-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-2-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-2-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-3-ip-10-0-140-109.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   installer-3-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Pending     kube-apiserver-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-1-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-2-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-2-ip-10-0-166-238.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-3-ip-10-0-140-109.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Succeeded   revision-pruner-3-ip-10-0-159-71.ec2.internal
Apr 22 17:35:10 ip-10-0-12-47 openshift.sh[1518]: Not all pods available yet. Waiting for 5 seconds...

openshift.sh runs after bootkube and attemps to wait for the kube-apiserver to look healthy.
The wait is a little unusual in and of itself (you contacted the server, why wait), but
it should wait on the openshift-kube-apiserver namespace since that's the one that runs
the kube-apiserver.
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: abhinavdahiya

If they are not already assigned, you can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya abhinavdahiya removed the request for review from aaronlevy April 22, 2019 18:31
@abhinavdahiya
Copy link
Copy Markdown
Contributor

/assign @wking

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Apr 22, 2019

made it through bootstrapping. Based on slack I think @wking prefers #1659 though

/retest

@wking
Copy link
Copy Markdown
Member

wking commented Apr 22, 2019

Went with #1659 instead.

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: Closed this PR.

Details

In response to this:

Went with #1659 instead.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants