Skip to content

pkg/asset/ignition/machine/node: Move pointer Ignition configs to api-int#1693

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:pointer-ignition-config-from-api-int
May 1, 2019
Merged

pkg/asset/ignition/machine/node: Move pointer Ignition configs to api-int#1693
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:pointer-ignition-config-from-api-int

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Apr 30, 2019

Catching up with 13e4b70 (#1601) and 052fcee (#1633).

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2019
@wking wking force-pushed the pointer-ignition-config-from-api-int branch from 8b82337 to a7fa6fa Compare April 30, 2019 20:27
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Apr 30, 2019

/test e2e-libvirt
/test e2e-metal
/test e2e-vsphere

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Apr 30, 2019

/test e2e-libvirt
/test e2e-metal

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Apr 30, 2019

/test e2e-libvirt

@wking wking changed the title pkg/asset/ignition/machine/node: Move pointer Igntion configs to api-int pkg/asset/ignition/machine/node: Move pointer Ignition configs to api-int Apr 30, 2019
@wking
pkg/asset/ignition/machine/node: Move pointer Ignition configs to api…
b846d9e 
…-int

Catching up with 13e4b70 (data/aws: create an api-int dns name,
2019-04-11, openshift#1601) and 052fcee (asset/manifests: use internal
apiserver name, 2019-04-17, openshift#1633).
@wking wking force-pushed the pointer-ignition-config-from-api-int branch from a7fa6fa to b846d9e Compare April 30, 2019 21:05
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Apr 30, 2019

/test e2e-metal

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Apr 30, 2019

/test e2e-vsphere

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Apr 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Apr 30, 2019

/retest

@praveenkumar
Copy link
Copy Markdown
Contributor

praveenkumar commented May 1, 2019

/test e2e-libvirt

@wking
Copy link
Copy Markdown
Member Author

wking commented May 1, 2019

e2e-aws-upgrade:

level=error msg="\t* aws_route53_zone.int: error waiting for Route53 Hosted Zone (Z122A9EA0YKC5T) creation: timeout while waiting for state to become 'INSYNC' (last state: 'PENDING', timeout: 15m0s)"

/retest

@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented May 1, 2019

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 1, 2019 •
edited
Loading

@wking: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-libvirt b846d9e link /test e2e-libvirt

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ef2362d into openshift:master May 1, 2019
@wking wking deleted the pointer-ignition-config-from-api-int branch May 1, 2019 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@sdodson sdodson Awaiting requested review from sdodson

Assignees

@abhinavdahiya abhinavdahiya

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wking @abhinavdahiya @openshift-ci-robot @praveenkumar @openshift-merge-robot