images/installer: update upi Dockerfile to fetch matchbox using releases#1730
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 8, 2019
Merged
Conversation
Repo `github.com/coreos/terraform-provider-matchbox` has moved ownership to `github.com/poseidon/terraforn-provider-matchox` [1] So the previous `go get github.com/coreos/terraform-provider-matchbox` now fails to build [2] as the new repo moved to new module [3] So the move to fetching the binary from the github released artifacts [4] seems like the better move. [1]: https://github.com/poseidon/terraform-provider-matchbox [2]: https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/1729/pull-ci-openshift-installer-master-images/4202 [3]: poseidon/terraform-provider-matchbox#43 [4]: https://github.com/poseidon/terraform-provider-matchbox/releases/tag/v0.2.3
Contributor
Author
|
/test e2e-metal |
openshift-ci-robot
added
size/S
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, staebler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/retest |
Member
|
/test e2e-aws-upgrade |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repo
github.com/coreos/terraform-provider-matchboxhas moved ownership togithub.com/poseidon/terraforn-provider-matchox1So the previous
go get github.com/coreos/terraform-provider-matchboxnow fails to build 2 as the new repo moved to new module 3So the move to fetching the binary from the github released artifacts 4 seems like the better move.
/cc @wking @staebler