Skip to content

data/data/openstack: Remove cluster name from servers#1820

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tomassedovic:openstack-hostnames
Jun 6, 2019
Merged

data/data/openstack: Remove cluster name from servers#1820
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
tomassedovic:openstack-hostnames

Conversation

@tomassedovic
Copy link
Copy Markdown
Contributor

@tomassedovic tomassedovic commented Jun 5, 2019

The convention for the fully-qualified names is
master-$index.$cluster_name.$domain_name, but the hostnames we were
setting were in the $cluster_name-master-$index format.

The master and bootstrap Ignition configs now drop the $cluster_name
prefix and only set the master-$index / bootstrap part.

@tomassedovic
data/data/openstack: Remove cluster name servers
5de8059 
The convention for the fully-qualified names is
`master-$index.$cluster_name.$domain_name`, but the hostnames we were
setting were in the `$cluster_name-master-$index` format.

The master and bootstrap Ignition configs now drop the `$cluster_name`
prefix and only set the `master-$index` / `bootstrap` part.
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 5, 2019
@tomassedovic
Copy link
Copy Markdown
Contributor Author

tomassedovic commented Jun 5, 2019

test e2e-aws-scaleup-rhel7 is not working now. I think this is ready for review/merging.

@tomassedovic
Copy link
Copy Markdown
Contributor Author

tomassedovic commented Jun 5, 2019

/assign @trown

@tomassedovic tomassedovic changed the title data/data/openstack: Remove cluster name servers data/data/openstack: Remove cluster name from servers Jun 5, 2019
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Jun 5, 2019

/test e2e-azure

1 similar comment
@abhinavdahiya
Copy link
Copy Markdown
Contributor

abhinavdahiya commented Jun 5, 2019

/test e2e-azure

@mandre
Copy link
Copy Markdown
Member

mandre commented Jun 6, 2019

/lgtm

The e2e-aws-scaleup-rhel7 and e2e-azure failures are unrelated.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4afbcdf into openshift:master Jun 6, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jun 6, 2019

@tomassedovic: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 5de8059 link /test e2e-aws-scaleup-rhel7
ci/prow/e2e-azure 5de8059 link /test e2e-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@markmc markmc mentioned this pull request Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@mandre mandre

@trown trown

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tomassedovic @abhinavdahiya @mandre @openshift-ci-robot @openshift-bot @trown @openshift-merge-robot