add Tags Name for Master and Worker Nodes in the Cloudformation UPI AWS#1996
add Tags Name for Master and Worker Nodes in the Cloudformation UPI AWS#1996rcarrata wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
|
Hi @rcarrata. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rcarrata The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/assign @abhinavdahiya |
There was a problem hiding this comment.
We usually have them indexed from 0
There was a problem hiding this comment.
@abhinavdahiya sure! I changed the code, and now are indexed from 0.
Can you please review the changes?
|
/ok-to-test /test e2e-aws-upi |
openshift-ci-robot
added
ok-to-test
|
@abhinavdahiya could you please check the 2 CI jobs that failed? Is due to the modificacions of the tagName into the Cloudformation Templates? Thanks in advance! |
|
/test e2e-aws-upi |
|
@rcarrata: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Can you please link the bugzilla for this change. With openshift working towards 4.2 only approved features are allowed to merge to installer. |
|
ping @rcarrata
|
|
We don't need tags on these machines, do we? For example, see 9572a06 (#1649), removing a number of things from the templates that we don't actually need for a successful UPI flow. The templates are not intended to provide a comfortable working environment, they're intended to show the minimal requirements for a functioning cluster. Obviously feel free to add usability stuff like this locally when launching your cluster, but I don't think we want unnecessary tags and such in the official templates. |
|
Also note that you can do things like: $ aws cloudformtation create-stack --tags Key=Name,Value=your-infra-name-worker-0 ...to create a compute machine from the |
/close I think the information provided by @wking should be a valid solution. |
|
@abhinavdahiya: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
What is this PR for?
When a OCP 4.x is deployed in UPI mode using the AWS Cloudformations templates, there is not the proper Tag Names for the Workers and Masters Nodes deployed (ec2 instances tag names).
Furthermore, there isn't tagged the security groups.
For this reason is complicated to identify which one are the masters or the workers nodes deployed (and also who is the master1, 2 or 3). Same thing for the security groups of master/worker nodes.
What is this PR About?
This PR add the tag name for the worker / master nodes (ec2 instances vm), giving a describing name for each one of them. Furthermore, also define the tag names for the security groups attached to master/worker nodes.
How is this PR tested?
The code pull requested is tested in OCP upi 4.1.3/4.1.4 and worked perfectly. The ec2 instances for masters/workers were identified easily, as same as the security groups attached to them.