installer: Fix some typos in workflow/workflow.go#2
Closed
felixonmars wants to merge 1 commit intoopenshift:masterfrom
Closed
installer: Fix some typos in workflow/workflow.go#2felixonmars wants to merge 1 commit intoopenshift:masterfrom
felixonmars wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
needs-ok-to-test
Contributor
|
Hi @felixonmars. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XS
Member
|
Please send any PRs to github.com/coreos/tectonic-installer. We are in the process of figuring out how to transition, but for now, this repo is just a copy of that repo. |
gbenhaim
added a commit
to gbenhaim/installer
that referenced
this pull request
Mar 3, 2019
Adding CI and Build deps
This was referenced Jul 25, 2019
iamemilio
pushed a commit
to iamemilio/installer
that referenced
this pull request
Aug 16, 2019
Corrections by racedo
jomeier
added a commit
to jomeier/installer
that referenced
this pull request
Jan 31, 2020
suhanime
added a commit
to suhanime/installer
that referenced
this pull request
Nov 5, 2020
Backport for GCP uninstall leaking SA accounts
stbenjam
pushed a commit
to stbenjam/installer
that referenced
this pull request
Feb 10, 2021
add an owners file
BobbyRadford
pushed a commit
to BobbyRadford/installer
that referenced
this pull request
May 10, 2021
…lding IBM Cloud Scaffolding
bennerv
pushed a commit
to bennerv/installer
that referenced
this pull request
Jul 7, 2021
changing dnsmasq pre start script
zaneb
added a commit
to zaneb/openshift-installer
that referenced
this pull request
Apr 29, 2022
Start assisted service
patrickdillon
referenced
this pull request
in patrickdillon/installer
Oct 6, 2023
rvanderp3
referenced
this pull request
in openshift-splat-team/installer
Apr 14, 2026
Add vSphere privilege validation logic using component-specific privilege lists. Validates that each OpenShift component account (installer, machine-api, csi-driver, cloud-controller, diagnostics) has required vCenter permissions before installation proceeds. Implementation: - PrivilegeValidator struct with ValidateComponentPrivileges method - ValidationResult struct with Valid, MissingPrivileges, Scope fields - GetRequiredPrivileges() function with comprehensive privilege lists - Installer: ~45 privileges for infrastructure deployment - Machine API: ~35 privileges for VM lifecycle - CSI Driver: ~12 privileges for storage provisioning - Cloud Controller: ~10 read-only privileges for node discovery - Diagnostics: ~5 read-only privileges for troubleshooting Test coverage: - 9 test scenarios covering all acceptance criteria - Missing privilege detection (machine-api, csi-driver) - Successful validation for all components - Component-specific privilege sets - Error handling Foundation for Story #4: Privilege Validation Parent Epic: #2 - vSphere Multi-Account Credentials Depends on: Story #3 (schema extension) Related: openshift-splat-team/splat-team#4 Related: openshift-splat-team/splat-team#2 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.