Skip to content

OpenStack: Check octavia support #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 18, 2019
Merged

OpenStack: Check octavia support #2017

openshift-merge-robot merged 1 commit into from
Jul 18, 2019

Conversation

@luis5tb
Copy link
Contributor

@luis5tb luis5tb commented Jul 17, 2019

This PR checks if the OpenStack environment has Octavia
support

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 17, 2019
@luis5tb
Copy link
Contributor Author

luis5tb commented Jul 17, 2019

/assign @tomassedovic

@luis5tb
Copy link
Contributor Author

luis5tb commented Jul 17, 2019

/assign @wking

@luis5tb
OpenStack: Check octavia support
6cbb090 
This PR checks if the OpenStack environment has Octavia
support
@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 17, 2019 •
edited
Loading

I believe the e2e-openstack failure is fixed by #2018

@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 17, 2019

/lgtm
/approve

/hold

I've tested this locally and could not reproduce e2e-openstack failure. Still, putting this on hold until we merge #2018 because I'm quite confident it will fix the CI issues.

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 17, 2019
@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 17, 2019

/test e2e-openstack

@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 17, 2019

/retest

I think this time it looks like OpenStack just timed out.

@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 17, 2019

/hold cancel
/approve

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2019
@tomassedovic
Copy link
Contributor

tomassedovic commented Jul 17, 2019

@luis5tb this touches Gopkg.lock so it needs an approval from someone on the installer core team. It's got my lgtm tho.

@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Jul 17, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, luis5tb, tomassedovic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2019
@dulek
Copy link
Contributor

dulek commented Jul 17, 2019

/test e2e-aws-scaleup-rhel7

1 similar comment
@dulek
Copy link
Contributor

dulek commented Jul 17, 2019

/test e2e-aws-scaleup-rhel7

@luis5tb
Copy link
Contributor Author

luis5tb commented Jul 17, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 94b4431 into openshift:master Jul 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 18, 2019

@luis5tb: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-scaleup-rhel7 6cbb090 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

@tomassedovic tomassedovic

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@luis5tb @tomassedovic @abhinavdahiya @openshift-ci-robot @dulek @openshift-bot @wking @openshift-merge-robot