baremetal: keepalived/coredns pods remove before create#2033
baremetal: keepalived/coredns pods remove before create#2033hardys wants to merge 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/M
|
cc @celebdor and @cybertron |
|
/lgtm |
|
/label platform/baremetal |
If the container exists unexpectedly for any reason, then ExecStop not called, and sometimes there are "storage for container removed" errors trying to re-start it, presumably because podman cleanup removes resources for exited containers. So we add --rm on the podman create, and add logic to be completely sure any stale containers are removed on startup of the services. Closes: openshift#2032
|
New changes are detected. LGTM label has been removed. |
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/916/ |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: celebdor, hardys The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@hardys: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/assign @steveej |
|
@abhinavdahiya Thanks for the previous review, comments addressed so would appreciate another review when you get a moment, anything else which needs addressing before this can merge? |
|
will this still be required if we move to static pods for bare-metal using mco-bootstrap... ? |
This should no longer required, now that openshift/machine-config-operator#1002 is in. /close |
|
@stbenjam: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8 participants
If the container exists unexpectedly for any reason, then
ExecStop not called, and sometimes there are "storage for container removed"
errors trying to re-start it, presumably because podman cleanup
removes resources for exited containers.
Closes: #2032