asset/cluster: inject installer info when creating #2125
Conversation
OpenShift telemetry is currently unable to report _how_ a cluster was installed (i.e. user-provisioned vs installer-provisioned). We currently use a heuristic to try to determine this information. This patch adds a ConfigMap immediately before cluster creation with information about the installer. This ConfigMap is not present when the user provisions the cluster themselves since it isn't injected until the Terraform variables are generated. This ConfipMap contains the installer version and the name of the invoker (can be overridden with the OPENSHIFT_INSTALL_INVOKER environment variable). This will allow us to determine whether a cluster was user-provisioned or installer- provisioned, whether or not a custom build of the installer was used, and who created the cluster (e.g. Hive, CI). This commit cherry-picks 253126f (asset/cluster: inject installer info when creating, 2019-06-21, openshift#1890), although it's not a clean pick because of conflicting context in the imports between the master branch and this release-4.1 line [1]. [1]: openshift#1890 (comment)
|
@wking: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
wking
added
the
bugzilla/valid-bug
|
I've added |
would be useful to land entire set of changes in single PR, they can be separate commits.. |
|
I'd prefer to land the PRs together since this one on its own is a privacy concern. |
253126f introduced this so that our telemetry could distinguish between a user, our CI, and other future invokers of the installer. There are privacy concerns around collecting the actual username, so we'll just use "user" instead. This commit is a clean cherry-pick of c5ff3aa (asset/cluster: don't record usernames, 2019-07-18, openshift#2046).
|
/lgtm @jwforres is the patch manager for this round, so I'll let her apply the necessary labels. We may have missed this round though (that's my fault). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/hold Get the robot to stop pounding the scaleup test. |
openshift-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
crawford
added
the
cherry-pick-approved
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6 participants
This pull-request cherry-picks 253126f (#1890), although it's not a clean pick because of conflicting context in the imports between the master branch and this release-4.1 line. Once this PR lands, we can use
/cherrypick release-4.1to backport the follow-up #2046./assign @crawford