Skip to content

Conversation

@sallyom
Copy link
Contributor

@sallyom sallyom commented Sep 11, 2019

Once this PR merges, this change will result in following output:
from openshift-install binary extracted using oc adm release extract --tools

$ ./openshift-install version
./openshift-install unreleased-master-1740-g0fa196009983ef49d041366ab9c6d02148d6b69e
built from commit 0fa196009983ef49d041366ab9c6d02148d6b69e
release image quay.io/sallyom/release@sha256:7cab74f2faa7ef798c62b95f27bc80ad71c265071dc083eaada72db370982cac
release 4.2.0-0.ci-2019-09-11-114219

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 11, 2019
Copy link
Contributor Author

@sallyom sallyom Sep 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️ not sure, could just not print that line if not using extract.

@sallyom
Copy link
Contributor Author

sallyom commented Sep 11, 2019

/assign @wking

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sallyom
To complete the pull request process, please assign wking
You can assign the PR to them by writing /assign @wking in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sallyom sallyom force-pushed the update-pullspec-version branch 2 times, most recently from b169fc3 to 19e9e3b Compare September 11, 2019 21:50
@abhinavdahiya
Copy link
Contributor

I don't think the release name is important for the output of openshift-install version
oc adm release info <release image> should be the correct way for user to find that out.

version should print shorter releaseName
as well as the full image-digest.
@sallyom sallyom force-pushed the update-pullspec-version branch from 19e9e3b to ba2baac Compare September 11, 2019 22:28
@sallyom
Copy link
Contributor Author

sallyom commented Sep 11, 2019

I don't think the release name is important for the output of openshift-install version
oc adm release info <release image> should be the correct way for user to find that out.

@wking wdyt? doesn't matter to me either way, I'm adding the info for oc, don't have to use it in installer. Maybe installer should print the payload version if/only if using 'oc adm release extract', leave the line out otherwise.

@sallyom
Copy link
Contributor Author

sallyom commented Sep 12, 2019

closing since seems this isn't required and the oc change would not be backwards compatible.

@sallyom sallyom closed this Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants