upi/gcp: templates to use zone paramaters #2398
Conversation
openshift-ci-robot
added
the
size/M
docs/user/gcp/install_upi.md
Outdated
There was a problem hiding this comment.
They appear to, yes. However, this is ultimately a mapping of zones to masters... the zones could be used more than once if a case is found where this is not true.
Before this change, the GCP UPI workflow hard coded the zones in the
bootstrap and control-plane templates. It assumed every region had zones
$REGION-{a,b,c}. However, in some regions this is not the case.
This change adds the zone(s) as parameters to the templates and updates
the docs accordingly. The list of zones is now fetched from gcp, and
then used to populate the templates.
|
/retest |
|
/ltgm Although I expect we'll keep failing the unrelated CI jobs until origin gets sorted post-rebase. |
|
/retest |
|
@wking s/ltgm/lgtm/ |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, jstuever The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/test e2e-aws-upgrade |
|
Dunno what this is: /retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 participants
Before this change, the GCP UPI workflow hard coded the zones in the
bootstrap and control-plane templates. It assumed every region had zones
$REGION-{a,b,c}. However, in some regions this is not the case.
This change adds the zone(s) as parameters to the templates and updates
the docs accordingly. The list of zones is now fetched from gcp, and
then used to populate the templates.