pkg/destroy/aws: Dynamic partitions, fixing hard-coded 'aws' #2453
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
wking
force-pushed
the
aws-partition-handling
branch
2 times, most recently
from
3a034c0 to
1331497
Compare
Partitions are more complicated than I thought when I wrote the hard-coded arn:aws:ec2:... prefix in 54cfed5 (pkg/destroy/aws/aws: Return ARNs from terminateEC2InstancesByTags, 2019-08-13, openshift#2169). While most of our regions use 'aws', China uses aws-cn [1], GovCloud uses aws-us-gov [2], and there may be more. Pull this ARN componet from the AWS SDK instead to track that sort of thing. The Gopkg.lock bump was generated with: $ dep ensure using: $ dep version dep: version : v0.5.1 build date : 2019-03-20 git hash : faa61893 go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false [1]: https://docs.aws.amazon.com/general/latest/gr/aws-arns-and-namespaces.html#arns-syntax [2]: https://docs.aws.amazon.com/sdk-for-go/api/aws/endpoints/#pkg-overview
wking
force-pushed
the
aws-partition-handling
branch
from
1331497 to
d5dc471
Compare
|
Green enough. /assign @abhinavdahiya |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
5 participants
Partitions are more complicated than I thought when I wrote the hard-coded
arn:aws:ec2:...prefix in 54cfed5 (#2169). While most of our regions useaws, China usesaws-cn, GovCloud usesaws-us-gov, and there may be more. Pull this ARN componet from the AWS SDK instead to track that sort of thing.