kubelet: wait for network-online to start kubelet#2549
kubelet: wait for network-online to start kubelet#2549rphillips wants to merge 1 commit intoopenshift:masterfrom
Conversation
Fixes a race when the kubelet starts up to enumerate the hostname. ref: https://bugzilla.redhat.com/show_bug.cgi?id=1763700
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rphillips The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
How is this bug useful to the bootstrap kubelet service, we don't configure it to connect to any API. |
|
I am just thinking of parity with the MCO. |
|
@rphillips: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Yeah, I requested this just because in the past we've let the installer copy drift. But you're also right this particular change probably doesn't matter. So, shrug - no real strong opinion from me. |
|
Going to close this... We can reopen if we need to. |
Fixes a race when the kubelet starts up to enumerate the hostname.
Ports over a change from the MCO.
ref: https://bugzilla.redhat.com/show_bug.cgi?id=1763700
ref: openshift/machine-config-operator#1206
holding until the MCO PR merges in.
/hold