pkg/asset/machines/baremetal: Drop unused networkInterfaceAddress from provider()#2598
Conversation
…m provider() We've had the argument since the package landed in 0055065 (baremetal: add baremetal IPI platformo, 2019-07-16, openshift#1873), but it has never been used. Drop it to simplify the function calls, and to make it easier to use grep to answer questions like "does metal actually care about machineCIDR?" (apparently not).
openshift-ci-robot
added
size/XS
|
@wking: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: russellb, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
We've had the argument since the package landed in 0055065 (#1873), but it has never been used. Drop it to simplify the function calls, and to make it easier to use
grepto answer questions like "does metal actually care about machineCIDR?" (apparently not).