Skip to content

[fcos] Add vrutkovs and LorbusChris to OWNERS#2601

Merged
openshift-merge-robot merged 1 commit intoopenshift:fcosfrom
vrutkovs:fcos-owners-vrutkovs
Oct 31, 2019
Merged

[fcos] Add vrutkovs and LorbusChris to OWNERS#2601
openshift-merge-robot merged 1 commit intoopenshift:fcosfrom
vrutkovs:fcos-owners-vrutkovs

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Oct 31, 2019

This should help us to iterate faster and override e2e results until these are passing.

This only affects fcos branch and won't be transferred into master or release-*

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 31, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/gofmt 37561d5 link /test gofmt
ci/prow/e2e-aws 37561d5 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@abhinavdahiya
Copy link
Copy Markdown
Contributor

/cc @sdodson

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Oct 31, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Oct 31, 2019

Which branch was fcos forked from?

@vrutkovs
Copy link
Copy Markdown
Contributor Author

It was forked from master about a week ago

@vrutkovs
Copy link
Copy Markdown
Contributor Author

@sdodson mind overriding failing tests?

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Oct 31, 2019

@sdodson mind overriding failing tests?

Sure, you'll need to fix them otherwise you'll need me to override going forward. Probably just merging from master would fix the gofmt.

/override ci/prow/e2e-aws
/override ci/prow/gofmt

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-aws, ci/prow/gofmt

Details

In response to this:

@sdodson mind overriding failing tests?

Sure, you'll need to fix them otherwise you'll need me to override going forward. Probably just merging from master would fix the gofmt.

/override ci/prow/e2e-aws
/override ci/prow/gofmt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 36ca119 into openshift:fcos Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants