Bug 1770441: OpenStack: unpack compressed image data #2645
Bug 1770441: OpenStack: unpack compressed image data
#2645openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
the
size/M
Fedosin
force-pushed
the
uncompress_image
branch
from
cbb084b to
ee03e4a
Compare
|
/lgtm |
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
We likely want a valid bug ID to merge this commit. I've created bz#1770441 for this.
There was a problem hiding this comment.
Nit: future releases of OpenStack (starting with train) will be able to work with compressed images. Could you perhaps add a note as "Possible future improvement"? I'm sure a lot of people would appreciate to only have to upload 700MB instead of 2GB if their glance service supports this feature.
There was a problem hiding this comment.
Yep, I'll update the patch in a minute
|
/retitle Bug 1770441: OpenStack: unpack compressed image data |
openshift-ci-robot
changed the title
|
@Fedosin: This pull request references Bugzilla bug 1770441, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/bugzilla refresh |
|
@mandre: This pull request references Bugzilla bug 1770441, which is valid. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Now we always download unpacked image data to the local filesystem and then upload it to Glance without any modifications. In the future we plan to provide only compressed data, but unfortunately OpenStack Glance is not able to work with it. So, we have to decompress the data first. This patch allows the installer to work with both compressed and uncompressed images. When compressed image is downloaded the installer decompresses the data into local cache and returns its path. For compressed images the workflow stays the same.
Fedosin
force-pushed
the
uncompress_image
branch
from
ee03e4a to
afc248f
Compare
|
/lgtm |
|
/test e2e-openstack |
|
/label platform/openstack |
|
/test e2e-aws |
|
/assign @sdodson |
|
/approve |
openshift-ci-robot
added
the
approved
|
@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1770441 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
9 participants
Now we always download unpacked image data to the local filesystem and then upload it to Glance without any modifications.
In the future we plan to provide only compressed data, but unfortunately OpenStack Glance is not able to work with it. So, we have to decompress the data first.
This patch allows the installer to work with both compressed and uncompressed images.
When compressed image is downloaded the installer decompresses the data into local cache and returns its path. For compressed images the workflow stays the same.