[FCOS] pkg/asset: Drop requirement for CLI specified pull secret#2781
[FCOS] pkg/asset: Drop requirement for CLI specified pull secret#2781openshift-merge-robot merged 1 commit intoopenshift:fcosfrom
Conversation
openshift-ci-robot
added
the
size/XS
sgreene570
changed the title
|
/assign @LorbusChris |
|
neat! |
openshift-ci-robot
added
the
approved
|
Looks good, needs
to pass tests /hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/override ci/prow/e2e-vsphere Known issue |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-vsphere Known issue |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@sgreene570: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-aws Known issues and flakes |
|
@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LorbusChris, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
5 participants
This PR lets the installer CLI accept empty pull secrets without throwing an error, since OKD does not require a valid pull secret.