Skip to content

bootstrap: replace CRIO's hooks dir on bootstrap#2800

Closed
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
vrutkovs:crio-hooks-bootstrap
Closed

bootstrap: replace CRIO's hooks dir on bootstrap#2800
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
vrutkovs:crio-hooks-bootstrap

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Dec 12, 2019

This would ensure CRIO's bootstrap would use *COS-compatible hooks dir, since eventually these systems won't have oci-systemd-hooks RPM installed.

Master/worker PR: openshift/machine-config-operator#1314
FCOS PR: #2795

bootstrap: replace CRIO's hooks dir on bootstrap
e53b84f 
This would ensure CRIO's bootstrap would use FCOS-compatible hooks dir.

PR openshift/machine-config-operator#1311 would 
do the same for masters and workers
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 12, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign abhinavdahiya
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Dec 12, 2019

@vrutkovs: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-openstack e53b84f link /test e2e-openstack
ci/prow/e2e-aws e53b84f link /test e2e-aws
ci/prow/e2e-aws-upgrade e53b84f link /test e2e-aws-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters cgwalters mentioned this pull request Dec 14, 2019
Merged
@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Dec 14, 2019

I folded this in to #2807

@vrutkovs vrutkovs closed this Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jstuever jstuever Awaiting requested review from jstuever

@mtnbikenc mtnbikenc Awaiting requested review from mtnbikenc

Assignees

No one assigned

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vrutkovs @openshift-ci-robot @cgwalters