WIP: Configure BareMetal from the installer.#2849
WIP: Configure BareMetal from the installer.#2849imain wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Marked as WIP as I still need to add tests and properly functionally test. This patch also includes the vendoring from the API in PR openshift/api#540 This will have to land before this can be merged. |
There was a problem hiding this comment.
if these are optional, please add omitempty for json tag. also provide details on the default when not explicitly specified.
There was a problem hiding this comment.
Sorry need to straighten all these out. It's actually not optional even :).
Create a new baremetal deployment CRD containing all the elements needed to configure the baremetal deployment.
|
@imain: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Create a new baremetal deployment CRD containing all the elements needed
to configure the baremetal deployment.