vshpere: download ova into cache by jstuever · Pull Request #2922 · openshift/installer

jstuever · 2020-01-14T22:35:37Z

This change caches a copy of the vmware ova specified in rhcos.json in
preperation to upload the OVA into a Template.

Determine ova uri from rhcos.json
Download and cache ova
Enable override of ova uri in install-config.yaml

openshift-ci-robot · 2020-01-14T22:36:59Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign crawford
You can assign the PR to them by writing /assign @crawford in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jstuever · 2020-01-14T22:39:17Z

/uncc @jhixson74
/cc @jcpowermac

This change caches a copy of the vmware ova specified in rhcos.json in preperation to upload the OVA into a Template.

jstuever · 2020-01-24T18:38:39Z

/retest

jstuever · 2020-01-24T22:47:19Z

/retest

patrickdillon · 2020-01-29T02:44:06Z

 		if err != nil {
 			return errors.Wrapf(err, "failed to get %s Terraform variables", platform)
 		}
+		installConfig.Config.VSphere.ClusterOSImage = cachedImage


What is the effect of doing this? Is this value saved or used later?

The goal here is to stuff the cached location back into the installConfig so we can pass it to the preterraform func. https://github.com/openshift/installer/pull/2922/files#diff-661643e1b9745123649391076bfa5a01R22. I don't believe it's ever written out to disk, though.

I don't think you can assume writeback to your dependency assets, the asset store could easily be providing you the ready only copies.

dependency loops are not great.

patrickdillon · 2020-01-29T02:45:19Z

One question https://github.com/openshift/installer/pull/2922/files#r372164571 but
/lgtm

jstuever · 2020-02-03T19:08:24Z

/retest

jstuever · 2020-02-04T16:23:12Z

/retest

openshift-ci-robot · 2020-02-04T20:28:46Z

@jstuever: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-ovirt	`882ac28`	link	`/test e2e-ovirt`
ci/prow/e2e-libvirt	`882ac28`	link	`/test e2e-libvirt`
ci/prow/e2e-aws-scaleup-rhel7	`882ac28`	link	`/test e2e-aws-scaleup-rhel7`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jstuever · 2020-02-20T00:23:31Z

/unassign @patrickdillon
/assign @abhinavdahiya
for your approval.

abhinavdahiya · 2020-02-20T01:00:50Z

+// PreTerraform performs any infrastructure initialization which must
+// happen before Terraform creates the remaining infrastructure.
+func PreTerraform(ctx context.Context, infraID string, installConfig *installconfig.InstallConfig) error {
+	// TODO: create VM Template using cachedImage
+	return nil
+}


the goal for pre terraform was to put in code that was not easily done by terraform itself, like tagging subnets for AWS.

my preference would be keep any cloud creation into terraform, we can easily keep local terraform providers for the custom objects/operations like the uploading ova.

abhinavdahiya · 2020-02-20T01:03:32Z

I think there is a serious issue with
a) updating an dependency from tfvars asset.
b) the setup of pre-terraform for ova. one i don't think this PR needs that changeset, another that we need to follow that path.

jstuever · 2020-02-26T23:11:12Z

Going to be solved a different way.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 14, 2020

openshift-ci-robot requested review from jhixson74 and patrickdillon January 14, 2020 22:36

openshift-ci-robot requested review from jcpowermac and removed request for jhixson74 January 14, 2020 22:39

jcpowermac reviewed Jan 15, 2020

View reviewed changes

Comment thread pkg/rhcos/vmware.go Outdated

jstuever force-pushed the cors1337 branch 2 times, most recently from 9201d19 to 7a14ed3 Compare January 18, 2020 22:43

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2020

jstuever force-pushed the cors1337 branch 2 times, most recently from 7120267 to d85bfa0 Compare January 18, 2020 23:41

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2020

jstuever force-pushed the cors1337 branch from d85bfa0 to 76e1a4b Compare January 20, 2020 18:32

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 20, 2020

jstuever force-pushed the cors1337 branch 3 times, most recently from 30edba5 to 533209b Compare January 22, 2020 19:01

jstuever changed the title ~~[WIP] vshpere: download ova and create template~~ [WIP] vshpere: download ova into cache Jan 22, 2020

vshpere: download ova into cache

882ac28

This change caches a copy of the vmware ova specified in rhcos.json in preperation to upload the OVA into a Template.

jstuever force-pushed the cors1337 branch from 533209b to 882ac28 Compare January 23, 2020 18:16

openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2020

jcpowermac mentioned this pull request Jan 24, 2020

Add import ova for vSphere #2970

Closed

5 tasks

jstuever changed the title ~~[WIP] vshpere: download ova into cache~~ vshpere: download ova into cache Jan 24, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2020

jstuever requested a review from jcpowermac January 24, 2020 18:38

patrickdillon reviewed Jan 29, 2020

View reviewed changes

openshift-ci-robot assigned patrickdillon Jan 29, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2020

openshift-ci-robot assigned abhinavdahiya and unassigned patrickdillon Feb 20, 2020

abhinavdahiya reviewed Feb 20, 2020

View reviewed changes

jstuever closed this Feb 26, 2020

jstuever deleted the cors1337 branch June 17, 2020 22:32

Conversation

jstuever commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 14, 2020

Uh oh!

jstuever commented Jan 14, 2020

Uh oh!

Uh oh!

jstuever commented Jan 24, 2020

Uh oh!

jstuever commented Jan 24, 2020

Uh oh!

patrickdillon Jan 29, 2020

Choose a reason for hiding this comment

Uh oh!

jstuever Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

abhinavdahiya Feb 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

patrickdillon commented Jan 29, 2020

Uh oh!

jstuever commented Feb 3, 2020

Uh oh!

jstuever commented Feb 4, 2020

Uh oh!

openshift-ci-robot commented Feb 4, 2020

Uh oh!

jstuever commented Feb 20, 2020

Uh oh!

abhinavdahiya Feb 20, 2020

Choose a reason for hiding this comment

Uh oh!

abhinavdahiya commented Feb 20, 2020

Uh oh!

jstuever commented Feb 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jstuever commented Jan 14, 2020 •

edited

Loading

abhinavdahiya Feb 20, 2020 •

edited

Loading