Skip to content

[FCOS] use stable Fedora CoreOS boot images#2947

Merged
openshift-merge-robot merged 1 commit intoopenshift:fcosfrom
vrutkovs:fcos-use-stable-stream
Jan 20, 2020
Merged

[FCOS] use stable Fedora CoreOS boot images#2947
openshift-merge-robot merged 1 commit intoopenshift:fcosfrom
vrutkovs:fcos-use-stable-stream

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Jan 19, 2020

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 19, 2020
@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Jan 19, 2020

/lgtm

@vrutkovs can you override the vsphere e2e here?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 19, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jan 19, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 19, 2020

I'd rather have it fixed it in #2671 first.

/hold
for now, as it might need a rebase

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2020
@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Jan 19, 2020

I'm fine with that :) Maybe we can hold it even until the OKD installer rebase on top of the #2745 has been merged (or force-pushed rather) - this here could then be the last commit before Beta 1.

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 19, 2020

/retest

@vrutkovs vrutkovs force-pushed the fcos-use-stable-stream branch from 8f72f82 to 8b23f05 Compare January 20, 2020 00:06
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 20, 2020

Updated OVA path, since UPI support got merged

@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Jan 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 20, 2020 •
edited
Loading

govc: unexpected EOF - network error during OVA upload

/retest

UPD It was a missing slash in baseURI

@vrutkovs vrutkovs force-pushed the fcos-use-stable-stream branch from 8b23f05 to de38d18 Compare January 20, 2020 00:41
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Jan 20, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@LorbusChris
Copy link
Copy Markdown
Contributor

LorbusChris commented Jan 20, 2020

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 20, 2020

@vrutkovs: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere de38d18 link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Jan 20, 2020

/override ci/prow/e2e-vsphere

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 20, 2020

@vrutkovs: Overrode contexts on behalf of vrutkovs: ci/prow/e2e-vsphere

Details

In response to this:

/override ci/prow/e2e-vsphere

/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged this pull request into openshift:fcos Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LorbusChris LorbusChris LorbusChris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LorbusChris LorbusChris

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrutkovs @LorbusChris @openshift-ci-robot @openshift-bot @openshift-merge-robot