Bug 1794765: ipv6: Fix IPv6 address encoding#2977
Bug 1794765: ipv6: Fix IPv6 address encoding#2977openshift-merge-robot merged 1 commit intoopenshift:release-4.3from
Conversation
You can't just manually join an IP and port because that will break with an IPv6 address. net.JoinHostPort() will do the right thing and add square brackets around an IPv6 address. Anywhere we may be using an IPv6 address in a URL needs similar handling. We need to ensure the IPv6 address always has square brackets in this case. An easy way to do this is to always specify the port number explicitly so we can use net.JoinHostPort(). Reported-by: Steven Hardy <shardy@redhat.com>
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
@russellb: This pull request references Bugzilla bug 1794765, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
|
/bugzilla refresh |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@russellb: This pull request references Bugzilla bug 1794765, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
removed
the
bugzilla/invalid-bug
|
/cc @stbenjam |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/lgtm |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
eparis
added
the
cherry-pick-approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@russellb: All pull requests linked via external trackers have merged. Bugzilla bug 1794765 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
You can't just manually join an IP and port because that will break
with an IPv6 address. net.JoinHostPort() will do the right thing and
add square brackets around an IPv6 address.
Anywhere we may be using an IPv6 address in a URL needs similar
handling. We need to ensure the IPv6 address always has square
brackets in this case. An easy way to do this is to always specify
the port number explicitly so we can use net.JoinHostPort().
Reported-by: Steven Hardy shardy@redhat.com