Skip to content

[FCOS] Installer expects the Azure storage account to be a page blob but it isn't#3006

Closed
jomeier wants to merge 1 commit intoopenshift:fcosfrom
jomeier:azure-fix-sa-page-blob
Closed

[FCOS] Installer expects the Azure storage account to be a page blob but it isn't#3006
jomeier wants to merge 1 commit intoopenshift:fcosfrom
jomeier:azure-fix-sa-page-blob

Conversation

@jomeier
Copy link
Copy Markdown
Contributor

@jomeier jomeier commented Jan 28, 2020

Hi,

the fcos image is downloaded from fedora coreos and uploaded to Azure because the Image is currently not in the Azure Marketplace because of legal issues.
And because without page blob mode the upload would take much longer it is enforced.

Greetings,

Josef

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Hi @jomeier. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@vrutkovs
Copy link
Copy Markdown
Contributor

/retitle [FCOS] Installer expects the Azure storage account to be a page blob but it isn't

@openshift-ci-robot openshift-ci-robot changed the title https://kubernetes.slack.com/archives/C6BRQSH2S/p1580229726043100?thread_ts=1580204680.022600&cid=C6BRQSH2S [FCOS] Installer expects the Azure storage account to be a page blob but it isn't Jan 28, 2020
@vrutkovs
Copy link
Copy Markdown
Contributor

/ok-to-test
/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@abhinavdahiya
Copy link
Copy Markdown
Contributor

How is this image different from RHCOS blobs on Azure? should be changed for RHCOS too?

@vrutkovs
Copy link
Copy Markdown
Contributor

/hold

@arithx PTAL. For OKD images need to be uploaded manually and I'm not sure if this PR is fixing this entirely

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@jomeier: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws 05d272c link /test e2e-aws
ci/prow/e2e-vsphere 05d272c link /test e2e-vsphere

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jomeier
Copy link
Copy Markdown
Contributor Author

jomeier commented Jan 28, 2020

/data/data/azure/main.tf contains azurerm_storage_blob { ... type = "Page" ...} but Terraform still creates a container of type "Block". Don't know why.

@jomeier
Copy link
Copy Markdown
Contributor Author

jomeier commented Feb 3, 2020

github.com//pull/3033

@jomeier jomeier closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants