Skip to content

baremetal: stop ironic on bootstrap after masters are booted #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stbenjam wants to merge 1 commit into from
Closed

baremetal: stop ironic on bootstrap after masters are booted #3075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions data/data/bootstrap/baremetal/files/usr/local/bin/startironic.sh.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,12 @@ sudo podman run -d --net host --privileged --name ironic-api \
--entrypoint /bin/runironic-api \
-v $IRONIC_SHARED_VOLUME:/shared:z ${IRONIC_IMAGE}

# See if Ironic API is up
while true; do
curl http://localhost:6385/v1 && break
sleep 10
done

# Now loop so the service remains active and restart everything should one of the containers exit unexpectedly.
# The alternative would be RemainAfterExit=yes but then we lose the ability to restart if something crashes.
while true; do
Expand All @@ -137,5 +143,15 @@ while true; do
exit 1
fi
done

# See if all 3 masters are up yet - if so we can bring down Ironic. If the masters are brought up, and
# machine-api is started in the cluster, there can end up being 2 DHCP servers running on the network.
# We must ensure we stop the bootstrap's Ironic before that can happen.
ACTIVE_NODES=$(curl -H "X-OpenStack-Ironic-API-Version: 1.9" 'http://localhost:6385/v1/nodes?provision_state=active' | jq '.nodes | length')
if [[ "$ACTIVE_NODES" == "3" ]]; then
Copy link
Copy Markdown

@hardys hardys Feb 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with this approach we'll need to template the number of nodes as I know some folks have tested with a single master

sleep 60
Copy link
Copy Markdown
Member Author

@stbenjam stbenjam Feb 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to wait for the hosts to be active, and give enough time for the installer to see that as well via it's polling

stopironic.sh
sleep infinity
fi
sleep 10
done