Skip to content

baremetal: add owners to bootstrap subdirectories#3144

Closed
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:baremetal-owners
Closed

baremetal: add owners to bootstrap subdirectories#3144
stbenjam wants to merge 1 commit intoopenshift:masterfrom
stbenjam:baremetal-owners

Conversation

@stbenjam
Copy link
Copy Markdown
Member

I didn't realize the OWNERS file in data/data/bootstrap/baremetal didn't
apply to subdirectories, so this adds it to usr/local/bin as well where
we host the ironic service scripts.

I didn't realize the OWNERS file in data/data/bootstrap/baremetal didn't
apply to subdirectories, so this adds it to usr/local/bin as well where
we host the ironic service scripts.
@stbenjam
Copy link
Copy Markdown
Member Author

/assign @sdodson

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 20, 2020
@sdodson
Copy link
Copy Markdown
Member

sdodson commented Feb 20, 2020

The behavior is to look at each changed file and walk the tree up from that path until it finds an OWNERS that covers that file. In #3079 you touched data/data/bootstrap/baremetal and pkg/asset/ignition/bootstrap/baremetal the latter lacks an OWNERS file so it walked to the top of the tree and used the default.

Hmm, I was wrong. I'm now not sure what happened.

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Feb 20, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2020
@abhinavdahiya
Copy link
Copy Markdown
Contributor

/hold

I think we need to talk to test platform team before we do this. This is odd

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@stbenjam: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 42cb9b2 link /test e2e-aws-fips
ci/prow/e2e-aws-upgrade 42cb9b2 link /test e2e-aws-upgrade
ci/prow/e2e-libvirt 42cb9b2 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 42cb9b2 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sdodson
Copy link
Copy Markdown
Member

sdodson commented Feb 24, 2020

/close
looks like it's working as intended

#3147 (comment)

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sdodson: Closed this PR.

Details

In response to this:

/close
looks like it's working as intended

#3147 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the baremetal-owners branch February 24, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants