Skip to content

Install cgroups config for bootstrap#3165

Closed
LorbusChris wants to merge 1 commit intoopenshift:masterfrom
LorbusChris:kubelet-cgroups
Closed

Install cgroups config for bootstrap#3165
LorbusChris wants to merge 1 commit intoopenshift:masterfrom
LorbusChris:kubelet-cgroups

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

Equivalent to openshift/machine-config-operator#581,
cherry-picked from fcos branch

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Copy Markdown
Contributor

How if this useful on bootstrap host?

@LorbusChris
Copy link
Copy Markdown
Contributor Author

I guess this may have been a precaution.
I'd be happy to drop this from fcos as well.
/cc @vrutkovs

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-ovirt 027ba08 link /test e2e-ovirt
ci/prow/e2e-aws-fips 027ba08 link /test e2e-aws-fips
ci/prow/e2e-libvirt 027ba08 link /test e2e-libvirt
ci/prow/e2e-aws-scaleup-rhel7 027ba08 link /test e2e-aws-scaleup-rhel7

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Copy Markdown
Contributor

AFAIK this file is present in RHCOS from the start, so it doesn't need to be re-created

@LorbusChris
Copy link
Copy Markdown
Contributor Author

Are you sure? Then MCO wouldn't have to add it either...
What is the benefit of this on bootstrap hosts?
Could we drop this from fcos?

@jstuever
Copy link
Copy Markdown
Contributor

/uncc @jstuever

@openshift-ci-robot openshift-ci-robot removed the request for review from jstuever February 27, 2020 19:06
@LorbusChris
Copy link
Copy Markdown
Contributor Author

@vrutkovs closing. Feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants