[fcos] Update UPI to Terraform 0.12.x#3222
Closed
LorbusChris wants to merge 111 commits intoopenshift:fcosfrom
Closed
[fcos] Update UPI to Terraform 0.12.x#3222LorbusChris wants to merge 111 commits intoopenshift:fcosfrom
LorbusChris wants to merge 111 commits intoopenshift:fcosfrom
Conversation
* Fixups for updated Terraform syntax * Ignition: With the new provider version the Ignition spec elements are required to be referenced by their `.rendered` property instead of `.id` * Azure: Fixes 'Warning: "attempts": [DEPRECATED] Retries are now handled by the Azure SDK as such this field is no longer necessary and will be removed in v2.0 of the Azure Provider'
The Terraform-provider bump brought in hashicorp/terraform-provider-aws@864285b1bb (Tagging for VPC Endpoints and VPC Endpoint Services, 2019-05-15, hashicorp/terraform-provider-aws#8674, v2.16.0). Also wire this into the deleteARN tree. VPC endpoint ARNs look like: arn:aws:ec2:{region}:{account}:vpc-endpoint/vpce-123...
The definition of the Compute Base Path has changed in the Google API and can't be used for determining Zone and Instance URLs anymore. This commit hardcodes the correct base path. A better way to do this should be found in the future to account for changes in the base path. Old Compute Base Path: https://www.googleapis.com/compute/v1/projects/ New Compute Base Path: https://compute.googleapis.com/compute/v1/projects/ Unchanged Zone URL: https://www.googleapis.com/compute/v1/projects/project-id/zones/us-central1-a
before proceeding. In OKD-on-FCOS, the bootstrap host runs FCOS and does not have the MCD binary included by default. This change gets the binary and pivots into the machine-os-content payload at an early stage.
…rvice This simplifies debugging when MCD image is being pulled
OVN attempts to resolve node name to find out its IP, so it cannot be phoney. OVN, unfortunately, doesn't use search domains, so in order to join the node CI terraform scripts use node IP as a name
[fcos] Update base image to 31.20200323.3.2
The UPI documentation recommends keeping the worker Machineset in case the user wants to create compute machines via the machine API. However, the Machineset won't work unless the `image` property is updated to the user-defined value. This change adds a recommendation to update the OS image in case the user wants to use the installer-provisioned Machineset.
Following objects are still present in the cluster, after deletion is completed: - Cinder volumes from PVs - Swift container for image registry (bootstrap container is correctly deleted)
The Boostrap Ignition file needs to be edited before it's uploaded. Before this change, the documentation described the "upload" step before the "edit" step.
Now if the function fails, we stop the installation immediately, but it's better to retry several times before finally stopping the installation.
Signed-off-by: Roy Golan <rgolan@redhat.com>
[fcos] Cherrypick few 4.4 fixes
…ty-operators [fcos] add a new upstream community operator source
…es and reorg - Update to terraform 0.12.x - ipam moved to a module and updated for 0.12 - creation of vsphere objects moved to module - removal of etcd dns records - domain dns records separated from creating rhcos node a records - create load balancer using openshift haproxy image and an additional rhcos virtual machine - create dns A record for lb ip and api, api-int, *.apps - change virtual machine ignition extra config to file path string vs ignition string. Simplifies bootstrap and other instance configuration - Updated Dockerfile CI UPI image for 0.12.24
LorbusChris
force-pushed
the
upi-vsphere-fixup
branch
2 times, most recently
from
eb6f6fd to
68d2174
Compare
openshift-ci-robot
removed
the
needs-rebase
LorbusChris
force-pushed
the
upi-vsphere-fixup
branch
4 times, most recently
from
d8a1d54 to
85423e7
Compare
Contributor
Author
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
LorbusChris
force-pushed
the
upi-vsphere-fixup
branch
from
85423e7 to
17c60fa
Compare
LorbusChris
changed the title
Contributor
Author
|
/test e2e-vsphere |
1 similar comment
Contributor
Author
|
/test e2e-vsphere |
Contributor
|
@LorbusChris: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with upi changes from master
Add a new tf template file for NetworkManager keyfiles
/cc @vrutkovs