Skip to content

Update error message when gather bootstrap fails from create cluster. #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patrickdillon wants to merge 1 commit into from
Closed

Update error message when gather bootstrap fails from create cluster. #3256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/openshift-install/create.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ var (
logrus.Error("Attempted to gather ClusterOperator status after installation failure: ", err2)
}
if err2 := runGatherBootstrapCmd(rootOpts.dir); err2 != nil {
logrus.Error("Attempted to gather debug logs after installation failure: ", err2)
logrus.Error("Attempted to gather debug logs after installation failure by running openshift-install gather bootstrap:", err2)
Copy link
Copy Markdown
Contributor

@abhinavdahiya abhinavdahiya May 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logrus.Error("Attempted to gather debug logs after installation failure by running openshift-install gather bootstrap:", err2)
logrus.Error("Failed to gather debug logs using openshift-install gather bootstrap: ", err2)

}
logrus.Fatal("Bootstrap failed to complete: ", err)
}
Expand Down
2 changes: 1 addition & 1 deletion cmd/openshift-install/gather.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func logGatherBootstrap(bootstrap string, port int, masters []string, directory
logrus.Info("Pulling debug logs from the bootstrap machine")
client, err := ssh.NewClient("core", net.JoinHostPort(bootstrap, strconv.Itoa(port)), gatherBootstrapOpts.sshKeys)
if err != nil && strings.Contains(err.Error(), "ssh: handshake failed: ssh: unable to authenticate") {
return errors.Wrap(err, "failed to create SSH client, ensure the private key is added to your authentication agent (ssh-agent) or specified with the --key parameter")
return errors.Wrap(err, "failed to create SSH session, ensure the private key is added to your authentication agent (ssh-agent) or specified with the --key parameter")
} else if err != nil {
return errors.Wrap(err, "failed to create SSH client")
}
Expand Down