Skip to content

Add ovirt to machine pools#3386

Closed
rolfedh wants to merge 1 commit intoopenshift:masterfrom
rolfedh:patch-1
Closed

Add ovirt to machine pools#3386
rolfedh wants to merge 1 commit intoopenshift:masterfrom
rolfedh:patch-1

Conversation

@rolfedh
Copy link
Copy Markdown
Contributor

@rolfedh rolfedh commented Mar 31, 2020

Added a line for platform = ovirt.
It's unclear why the target of the <platform>-specific properties links is also the section where the links are located, "Machine pools." We should update these targets and/or content to provide platform-specific properties.

Added a line for `platform` = `ovirt`. 
It's unclear why the target of the `<platform>-specific properties` links is also the section where the links are located, "Machine pools." We should update these targets and/or content to provide platform-specific properties.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign abhinavdahiya
You can assign the PR to them by writing /assign @abhinavdahiya in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

Hi @rolfedh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 31, 2020
* `azure` (optional object): [Azure-specific properties](azure/customization.md#machine-pools).
* `gcp` (optional object): [GCP-specific properties](gcp/customization.md#machine-pools).
* `openstack` (optional object): [OpenStack-specific properties](openstack/customization.md#machine-pools).
* `ovirt` (optional object): [oVirt-specific properties](openstack/customization.md#machine-pools).
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3183 will add ovirt customiztion

@openshift-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2020
@rgolangh
Copy link
Copy Markdown
Contributor

rgolangh commented Jun 30, 2020

/close
Obsoleted by #3690

@rgolangh
Copy link
Copy Markdown
Contributor

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rgolangh: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants