pkg/asset/installconfig: add vSphere TUI wizard by patrickdillon · Pull Request #3467 · openshift/installer

patrickdillon · 2020-04-15T23:36:23Z

This pull request adds the interactive wizard for creating a vSphere install config. After querying credentials from the user, the options are populated from the vCenter API. In cases where only one option is available, it is automatically selected.

This is WIP, but is mostly done, so I am posting for general feedback as well as specific feedback regarding networks. There seem to be four types of vSphere networks. In our vcenter there are DistributedVirtualPortGroups and DistributedVirtualSwitches, and some of these have children. Are all of these valid selections or should I be filtering some of them? The network list is pulled here: https://github.com/openshift/installer/compare/master...patrickdillon:vsphere-tui-cors-1415?expand=1#diff-8366d626249d949112555caeac30a52cR262

Here is a screenshot of the wizard:

On my to-do list:

add VIPs. This is manual entry and we'll just validate that the form is a valid IP so this is straightforward.
Currently if you are unable to login to vCenter the survey loops, continually asking you for username/pw until you can login. I thought this was cool, but survey doesn't work well with CTRL+C so if you CTRL+C trying to get out of this loop you can get an ugly error. I think I will just remove this and exit the installer if you can't login.

patrickdillon · 2020-04-15T23:37:07Z

/cc @jcpowermac

jcpowermac · 2020-04-16T13:25:36Z

This looks really good. The only thing from my perspective is the network comment.

jcpowermac · 2020-04-16T16:48:15Z

@patrickdillon #3470
for dnsvip removal

patrickdillon · 2020-04-16T19:41:17Z

I have addressed the networks issue and outstanding items, so I'm moving this out of WIP and I think it is ready.

jcpowermac · 2020-04-16T19:43:50Z

FYI: This won't pass /test e2e-vsphere since the dnsvip isn't there. And the changes to either the installer or mco hasn't merged yet.

patrickdillon · 2020-04-16T19:47:48Z

FYI: This won't pass /test e2e-vsphere since the dnsvip isn't there. And the changes to either the installer or mco hasn't merged yet.

e2e-vsphere has an install-config so this PR might incorrectly pass. But that reminds me we should update steps job. I will open a PR.

jcpowermac · 2020-04-16T19:49:06Z

/lgtm

abhinavdahiya · 2020-04-16T20:47:24Z

i think we should move this to debug.

I used Info because there is a noticeable delay for the network connection. This lets the user know what's happening and that the process is not frozen. The pause is very short, a few seconds in my case, so I'm willing to change but wanted to explain the reasoning.

This commit adds the survey prompts to create an install config. After querying the user for credentials, the wizard uses the vCenter API to present choices for all options.

abhinavdahiya · 2020-04-17T03:56:33Z

/lgtm
/approve

openshift-ci-robot · 2020-04-17T03:57:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [abhinavdahiya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-04-17T04:13:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-04-17T05:40:29Z

@patrickdillon: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-scaleup-rhel7	`48cc11e`	link	`/test e2e-aws-scaleup-rhel7`
ci/prow/e2e-openstack	`48cc11e`	link	`/test e2e-openstack`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-04-17T05:44:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

pkg/asset/installconfig/gcp: fix imports

003dfb8

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2020

openshift-ci-robot requested review from jhixson74 and mtnbikenc April 15, 2020 23:37

openshift-ci-robot requested a review from jcpowermac April 15, 2020 23:37

patrickdillon commented Apr 15, 2020

View reviewed changes

Comment thread pkg/asset/installconfig/vsphere/vsphere.go Outdated

jcpowermac reviewed Apr 16, 2020

View reviewed changes

Comment thread pkg/asset/installconfig/vsphere/vsphere.go Outdated

patrickdillon force-pushed the vsphere-tui-cors-1415 branch from 5dc7157 to 3d090b5 Compare April 16, 2020 19:39

patrickdillon changed the title ~~WIP: pkg/asset/installconfig: add vSphere TUI wizard~~ pkg/asset/installconfig: add vSphere TUI wizard Apr 16, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2020

openshift-ci-robot assigned jcpowermac Apr 16, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2020

abhinavdahiya reviewed Apr 16, 2020

View reviewed changes

Comment thread pkg/asset/installconfig/vsphere/vsphere.go Outdated

abhinavdahiya reviewed Apr 16, 2020

View reviewed changes

Comment thread pkg/asset/installconfig/vsphere/vsphere.go Outdated

patrickdillon force-pushed the vsphere-tui-cors-1415 branch from 3d090b5 to 6ba3d67 Compare April 17, 2020 01:36

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020

patrickdillon force-pushed the vsphere-tui-cors-1415 branch from 6ba3d67 to 335e931 Compare April 17, 2020 01:37

pkg/asset/installconfig: add vSphere TUI wizard

48cc11e

This commit adds the survey prompts to create an install config. After querying the user for credentials, the wizard uses the vCenter API to present choices for all options.

patrickdillon force-pushed the vsphere-tui-cors-1415 branch from 335e931 to 48cc11e Compare April 17, 2020 01:39

openshift-ci-robot assigned abhinavdahiya Apr 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020

openshift-merge-robot merged commit 19d22e6 into openshift:master Apr 17, 2020

Conversation

patrickdillon commented Apr 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

patrickdillon commented Apr 15, 2020

Uh oh!

Uh oh!

Uh oh!

jcpowermac commented Apr 16, 2020

Uh oh!

jcpowermac commented Apr 16, 2020

Uh oh!

patrickdillon commented Apr 16, 2020

Uh oh!

jcpowermac commented Apr 16, 2020

Uh oh!

patrickdillon commented Apr 16, 2020

Uh oh!

jcpowermac commented Apr 16, 2020

Uh oh!

abhinavdahiya Apr 16, 2020

Choose a reason for hiding this comment

Uh oh!

patrickdillon Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

abhinavdahiya commented Apr 17, 2020

Uh oh!

openshift-ci-robot commented Apr 17, 2020

Uh oh!

openshift-bot commented Apr 17, 2020

Uh oh!

openshift-ci-robot commented Apr 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Apr 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

patrickdillon commented Apr 15, 2020 •

edited

Loading

patrickdillon Apr 17, 2020 •

edited

Loading

openshift-ci-robot commented Apr 17, 2020 •

edited

Loading