Skip to content

installconfig: libvirt image prompt #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Sep 28, 2018
Merged

installconfig: libvirt image prompt #372

openshift-merge-robot merged 2 commits into from
Sep 28, 2018

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Sep 28, 2018

Add prompt for libvirt image, no change in default.

/cc @wking @crawford

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 28, 2018
wking
wking reviewed Sep 28, 2018
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also doc updates here and here (unwinding some of my removals from db640d0).

pkg/asset/installconfig/platform.go Outdated
Copy link
Member

@wking wking Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: os -> OS

pkg/asset/installconfig/platform.go Outdated
Copy link
Member

@wking wking Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spin this off into a local helper function to share with the libvirtd URI query?

pkg/asset/installconfig/platform.go Outdated
Copy link
Member

@wking wking Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The help makes this clear, but it might be worth updating this message to be Libvirtd URI to help folks who just need a small hint ;).

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Sep 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally i feel URI is enough. Do you have strong opinions on renaming it to LibvirtdURI ?

Copy link
Contributor

@crawford crawford Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to rename this to Libvirt Connection URI a while back.

@wking
Copy link
Member

wking commented Sep 28, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2018
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 28, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

crawford
crawford reviewed Sep 28, 2018
View reviewed changes
pkg/asset/installconfig/platform.go
Question: &survey.Question{
Prompt: &survey.Input{
Message: "Image",
Help: "URI for the OS image.",
Copy link
Contributor

@crawford crawford Sep 28, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URI of the OS image

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#376

@openshift-merge-robot openshift-merge-robot merged commit 0284d4e into openshift:master Sep 28, 2018
crawford
crawford reviewed Sep 28, 2018
View reviewed changes
docs/user/environment-variables.md
* `OPENSHIFT_INSTALL_LIBVIRT_IMAGE`:
The URI for the OS image.
For example it might be url like `http://aos-ostree.rhev-ci-vms.eng.rdu2.redhat.com/rhcos/images/cloud/latest/rhcos-qemu.qcow2.gz` or
a local file like `/tmp/openshift-install-853528428`.
Copy link
Contributor

@crawford crawford Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file:///tmp/openshift-install-853528428

Copy link
Contributor Author

@abhinavdahiya abhinavdahiya Sep 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#376

@abhinavdahiya abhinavdahiya deleted the libvirt_image branch September 28, 2018 22:40
abhinavdahiya added a commit to abhinavdahiya/installer that referenced this pull request Sep 28, 2018
@abhinavdahiya
fixes missed in PR openshift#372
f47c595
openshift-merge-robot added a commit that referenced this pull request Sep 29, 2018
@openshift-merge-robot
Merge pull request #376 from abhinavdahiya/libvirt_image
3b68ffb 
fixes missed in PR #372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking left review comments

+1 more reviewer

@crawford crawford crawford left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@abhinavdahiya @wking @openshift-ci-robot @crawford @openshift-merge-robot