machineconfig: Use nosmt KernelArgument now

[cgwalters]

This replaces #2805

Eventually it'd be nice to drop the deprecated /etc/pivot/
stuff from the MCO, this is a step towards that.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgwalters]

(No bug, this can wait for 4.7)

[abhinavdahiya]

https://github.com/openshift/machine-config-operator/blob/master/install/0000_80_machine-config-operator_01_machineconfig.crd.yaml#L70

That makes it feel like ignition field is required

[cgwalters]

Hmm possibly, I didn't test this locally; we also don't have CI coverage for this which probably needs to happen as a prerequisite. (It is IMO kind of a bug if the ignition section is really required becuase in exactly this case we're just using the "high level" MC section and not Ignition)

[LorbusChris]

As of today, at least this has to be passed:

ignConfig := igntypes.Config{
    Ignition: igntypes.Ignition{
	Version: igntypes.MaxVersion.String(),
    },
}

[openshift-ci-robot]

@cgwalters: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/unit	0f18ebe	link	/test unit
ci/prow/e2e-ovirt	0f18ebe	link	/test e2e-ovirt
ci/prow/e2e-libvirt	0f18ebe	link	/test e2e-libvirt
ci/prow/e2e-aws-fips	0f18ebe	link	/test e2e-aws-fips
ci/prow/e2e-metal-ipi	0f18ebe	link	/test e2e-metal-ipi
ci/prow/e2e-crc	0f18ebe	link	/test e2e-crc
ci/prow/e2e-aws-upgrade	0f18ebe	link	/test e2e-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[openshift-bot]

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

[openshift-ci-robot]

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.