[wip] bootkube.sh: handle retry of etcd-signer gracefully#4149
[wip] bootkube.sh: handle retry of etcd-signer gracefully#4149hexfusion wants to merge 1 commit intoopenshift:release-4.5from
Conversation
|
@hexfusion: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
c7786a9 to
a7d75c8
Compare
|
@hexfusion: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@hexfusion: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Going with full solution #4150 |
Issues covered by this PR.
Lets not print scary errors like the below
Instead in error lets just print
The trap is setup to make sure we try and remove etcd-signer container on error. Which serves its purpose. But after the bootstrap etcd has started lets not restart the signer if bootkube restarts. This way we can ensure signer is not competing with apiserver for ports.