Skip to content

Conversation

@abhinavdahiya
Copy link
Contributor

@abhinavdahiya abhinavdahiya commented Oct 5, 2018

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 5, 2018
@wking
Copy link
Member

wking commented Oct 5, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2018
@wking
Copy link
Member

wking commented Oct 5, 2018

/hold

Actually, do we need to remove this too?

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2018
@abhinavdahiya
Copy link
Contributor Author

/hold cancel

@deads2k suggestion is we try to remove the opensihft-api without replacement if we can.

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2018
@wking
Copy link
Member

wking commented Oct 5, 2018

Also, do we need #298 for this? coreos-inc/tectonic-operators#464 claims it as a dependency. I guess CI will tell us ;).

@abhinavdahiya
Copy link
Contributor Author

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 5, 2018
@abhinavdahiya abhinavdahiya force-pushed the drop_openshift_api branch 2 times, most recently from ff1ec44 to 1614e82 Compare October 5, 2018 19:25
@wking
Copy link
Member

wking commented Oct 5, 2018

e2e:

• Failure in Spec Setup (BeforeEach) [127.975 seconds]
[sig-storage] Secrets
/tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/common/secrets_volume.go:33
  should be consumable from pods in volume with defaultMode set [NodeConformance] [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s] [BeforeEach]
  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:684

  Expected error:
      <*errors.errorString | 0xc420093570>: {
          s: "timed out waiting for the condition",
      }
      timed out waiting for the condition
  not to have occurred

  /tmp/openshift/build-rpms/rpm/BUILD/origin-4.0.0/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/framework.go:217

Dunno if that's a flake or not.

@abhinavdahiya
Copy link
Contributor Author

investigating locally.

@abhinavdahiya
Copy link
Contributor Author

Requires openshift/origin#21183

@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 5, 2018
@abhinavdahiya
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2018
@deads2k
Copy link
Contributor

deads2k commented Oct 8, 2018

Requires openshift/origin#21183

origin pull merged and images have pushed.

@crawford
Copy link
Contributor

crawford commented Oct 8, 2018

/retest

@deads2k
Copy link
Contributor

deads2k commented Oct 8, 2018

/retest

needs a rebase.

@abhinavdahiya abhinavdahiya changed the title pkg/asset: update tectonic-operators pkg/asset: update tectonic-operators to drop all openshift apis. Oct 8, 2018
@abhinavdahiya abhinavdahiya changed the title pkg/asset: update tectonic-operators to drop all openshift apis. pkg/asset: update tectonic-operators to drop all openshift apis Oct 8, 2018
@openshift-bot openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 8, 2018
@abhinavdahiya
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2018
@crawford
Copy link
Contributor

crawford commented Oct 8, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, crawford, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,crawford,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e24cd60 into openshift:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants