-
Notifications
You must be signed in to change notification settings - Fork 1.5k
pkg/asset: update tectonic-operators to drop all openshift apis #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/asset: update tectonic-operators to drop all openshift apis #421
Conversation
|
/lgtm |
|
/hold Actually, do we need to remove this too? |
|
/hold cancel @deads2k suggestion is we try to remove the opensihft-api without replacement if we can. |
|
Also, do we need #298 for this? coreos-inc/tectonic-operators#464 claims it as a dependency. I guess CI will tell us ;). |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
ef424ee to
83c6937
Compare
ff1ec44 to
1614e82
Compare
|
e2e: Dunno if that's a flake or not. |
|
investigating locally. |
|
Requires openshift/origin#21183 |
1614e82 to
020bea4
Compare
|
/hold |
origin pull merged and images have pushed. |
|
/retest |
needs a rebase. |
https://github.com/coreos-inc/tectonic-operators/pull/464 merged changes that drop openshift-api.
020bea4 to
9a81c4d
Compare
|
/hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://github.com/coreos-inc/tectonic-operators/pull/464 merged changes that drop openshift-api.
/cc @deads2k @juanvallejo